add github action to implement #1490 contributor image#1497
Open
kjhollen wants to merge 1 commit intoprocessing:mainfrom
Open
add github action to implement #1490 contributor image#1497kjhollen wants to merge 1 commit intoprocessing:mainfrom
kjhollen wants to merge 1 commit intoprocessing:mainfrom
Conversation
Implements @skyash-dev's solution from the p5.js repository: - add a github action to generate the image in contributors-png.yml - add utils/contributors-png.js to use node & canvas to make an image - use processing-bot to generate a pull request with the new updated image when the all contributors file is changed - action only applies to processing/processing4 repo's main branch - add contributors.png file with current list of contributors (generated during testing) - make contributors.png visible in the README in the contributors section
Member
|
Definitely not a blocker: but potentially it's worth abstracting out both this and the p5 action into a separate action repo, like this one: https://github.com/processing/branch-pr-close-issue so the code is not duplicated in 2 places. @skyash-dev let me know if that would be of interest to you since you made the original action? I can make the repo and you could work on adding the action there and then updating the usages in processing4 and p5.js repos to use that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements @skyash-dev's solution from the p5.js repository: