Standardize class attributes in issue-scoped files#1324
Open
hxrshxz wants to merge 2 commits intoprocessing:mainfrom
Open
Standardize class attributes in issue-scoped files#1324hxrshxz wants to merge 2 commits intoprocessing:mainfrom
hxrshxz wants to merge 2 commits intoprocessing:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR standardizes HTML/CSS class attribute usage by replacing className with class on intrinsic/native markup, while leaving component props (e.g., <Icon className="..." />, <CircleButton className="..." />) unchanged. This aligns attribute usage across Astro and Preact-rendered templates and addresses #989.
Changes:
- Replaced
classNamewithclasson intrinsic elements in multiple TSX/JSX components. - Renamed an Astro prop destructure (
className→sectionClass) to avoid confusion and keepclasshandling explicit. - Minor cleanup/formatting improvements (e.g., removing debug logs, small refactors for readability).
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/SearchResults/index.tsx | Converts intrinsic element className attributes to class while keeping component className props intact. |
| src/components/RelatedItems/index.astro | Renames destructured class prop local variable and applies it via class={...}. |
| src/components/ReferenceDirectoryWithFilter/index.tsx | Updates intrinsic elements from className to class. |
| src/components/PageHeader/HomePage.astro | Small refactor to reuse heroImages and adds explicit callback parameter typing. |
| src/components/Nav/MainNavLinks.tsx | Updates intrinsic anchor className to class for CSS module usage. |
| src/components/Icon/index.tsx | Uses class={props.className} on SVG output while preserving the public prop name className. |
| src/components/Dropdown/index.tsx | Replaces intrinsic element className with class throughout the dropdown markup. |
| src/components/CopyCodeButton/index.tsx | Removes debug logging and keeps CircleButton’s className prop usage as a component prop. |
| src/components/CodeEmbed/index.jsx | Converts intrinsic element className to class and applies formatting-only refactors. |
| src/components/CircleButton/index.tsx | Applies class={...} on intrinsic <a>/<button> while continuing to accept a className prop. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Harsh <harshmastic@gmail.com>
3bef3c4 to
aa39945
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
classNameusage withclassin the current component and layout files covered by Feature: Standardize HTML class attribute naming (className → class) #989htmlElement.classNameuntouchedTesting
npm run checkclassNamehits are outside this diff or intentional (RelatedItemsalias,htmlElement.className)resolves #989