Fix stale asset usage meter - #4293
Open
seb-prjcts-be wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Related to #4085.
The asset usage meter currently prefers
user.totalSize, which is loaded with the authenticated session and can become stale after assets are uploaded or deleted. Although the asset-list request returns the current storage total and the assets reducer updates that total after deletion, the meter can continue displaying the older session value. The same precedence can also keep the upload-limit message stale after the asset list has loaded.Demo:
No screenshot included. This is a state-source correction and requires conflicting session and asset-list totals to reproduce.
Changes:
assets.totalSizeas the asset meter's current source of truthundefinedso the meter remains hidden until the asset request completes0 Btotal does not restore a stale positive session valueThis pull request contains one commit and changes only three existing client files. It does not include shared-asset-library changes.
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123git diff --checkpassed. I did not mark the dependency-based checks as complete because this fresh checkout does not containnode_modules.