GSOC-E2E: Add confirmation of sketch loading before playing it - #4282
Open
Geethegreat wants to merge 1 commit into
Open
GSOC-E2E: Add confirmation of sketch loading before playing it#4282Geethegreat wants to merge 1 commit into
Geethegreat wants to merge 1 commit into
Conversation
clairep94
reviewed
Sep 1, 2026
Comment on lines
120
to
+133
| // Confirm renamed sketch appears in the table | ||
| await expect( | ||
| page.locator('table.sketches-table').getByText('renamed-sketch') | ||
| ).toBeVisible({ timeout: 10_000 }); | ||
| await page | ||
| .locator('table.sketches-table') | ||
| .getByText('renamed-sketch') | ||
| .click(); | ||
|
|
||
| // Confirm the reopened sketch has actually loaded before playing it | ||
| await expect( | ||
| page.locator('button.editable-input__label') | ||
| ).toContainText('renamed-sketch', { timeout: 10_000 }); | ||
|
|
Collaborator
There was a problem hiding this comment.
@Geethegreat could you explain this a bit further?
How do we know that this is a good indicator of the sketch being loaded?
Member
Author
There was a problem hiding this comment.
The name and the files both come from the same API response and the same Redux dispatch (SET_PROJECT). As both reducers (project.js and files.js) react to that one action, state.project.name and state.files update together. So if we see the file name it implies that the file came with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes #
Demo:
Changes:
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123