Repository navigation
Fix iterated EKF measurement updates - #465
Open
Arthur031221 wants to merge 1 commit into
Open
Arthur031221 wants to merge 1 commit into
Arthur031221 wants to merge 1 commit into
Conversation
Keep the original prior during relinearization so each measurement is counted once. Test linear models and a nonlinear posterior mode.
Arthur031221
force-pushed
the
fix-iterated-update-double-count
branch
from
October 12, 2026 00:05
3ef4300 to
87d1a4d
Compare
Author
|
Rebased onto main and moved the EKF regressions into the current test module. This PR now covers only the iterated EKF update because the CMGF covariance solve needs a separate numerical design. The linear and nonlinear EKF regressions pass. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The iterated EKF uses the previous posterior for each update, counting the same observation more than once. Increasing
num_iterchanges the result even for linear models. The fix keeps the original prior and corrects the linearization residual at each iteration.Tested with the added linear and nonlinear regressions:
.venv/bin/python -m pytest -q -k iterated dynamax/nonlinear_gaussian_ssm/inference_test.py.Assisted by Claude/Codex.