Skip to content

GUI fixes for release - #307

Merged
davexparker merged 4 commits into
prismmodelchecker:masterfrom
davexparker:gui-fixes
Oct 9, 2026
Merged

davexparker merged 4 commits into
prismmodelchecker:masterfrom
davexparker:gui-fixes

Conversation

@davexparker

Copy link
Copy Markdown
Member

Small GUI fixes for the upcoming release.

  • Simulator: show transition probabilities with export precision (10 significant figures) rather than full toString() output.
  • Mac key bindings: add standard Cmd/Alt shortcuts to all text components (Cmd+C/X/V/A, Cmd+←/→/↑/↓, Alt+←/→, plus Shift-selection variants). These are missing because the GUI uses the cross-platform Metal look and feel. They are added to the look-and-feel's shared input maps, so they apply everywhere (e.g. the Property editor dialog), not just the model editor. No change on Linux/Windows.
  • Faster loading of large properties files: validate once after adding all properties, rather than after each one. From [GUI] Fixing slow loading of Property-files (Issue #230) #231 (fixes [GUI] Loading large Property-files takes very long #230); original authorship kept.
  • HTML escaping in property results: escape &, <, > in the Property Details dialog and the property list tooltip. Fixes GUI: Property result dialog garbles < in error message #39.

make test and unit tests pass; GUI changes checked manually on macOS.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused changes correctly implement the described fixes without identified regressions.

0 open findings

What changed in this PR

Adds targeted GUI fixes for the upcoming release.

Changes:

  • Formats simulator transition probabilities to 10 significant figures.
  • Adds macOS text-component shortcuts.
  • Batches property validation and escapes HTML in result displays.
File Description
GUIPropertyResultDialog.java Escapes result text for HTML display.
GUIProperty.java Adds shared plain-text-to-HTML conversion.
GUIPropertiesList.java Defers validation during bulk property loading.
GUIPrism.java Installs macOS text key bindings.
ModelGenerator.java Applies export precision to transition probabilities.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@davexparker
davexparker merged commit d4a723e into prismmodelchecker:master Oct 9, 2026
6 checks passed
@davexparker
davexparker deleted the gui-fixes branch October 9, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[GUI] Loading large Property-files takes very long GUI: Property result dialog garbles < in error message

3 participants