Repository navigation
feat: scaffold for Composer 0.35, with the entry in prisma.config.ts - #138
Merged
Merged
Conversation
Composer 0.35.0, which prisma 8.0.0-rc.28 ships, removed the entry argument from prisma dev and prisma deploy. The scaffold's composer section now sets entry: "./module.ts", and its scripts and the post-scaffold deploy run the commands without it. Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
Composer 0.35.0 names a node by its path from the app name, so dev's endpoint frame for the app service is <project>.app. Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
PR preview published
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At a glance
A project scaffolded by this PR gets this
composersection and these scripts:Before, the scaffold wrote no
entry, and its scripts ranprisma dev module.tsandprisma deploy module.ts.What this PR changes
prismamoves to 8.0.0-rc.28, and@prisma/composerand@prisma/composer-prisma-cloudmove to 0.35.0.prisma.config.tstemplate setsentry: "./module.ts"in thecomposersection.composer:devandcomposer:deployscripts, the deploy that runs after scaffolding, and its report step all runprisma devandprisma deploywithoutmodule.ts.Why
Composer 0.35.0, which
prisma8.0.0-rc.28 ships, removed the positional module argument fromdevanddeploy. The CLI now reads the module fromentryin thecomposersection ofprisma.config.ts, or from--entry <path>, and fails with "No entry module is set" when neither is there. Composer 0.34.0 rejectsentryin the section, so the pins and the template have to move together.The other pins stay as they are. Composer 0.35.0 still depends on
alchemy2.0.0-beta.83 andeffect4.0.3, and@prisma/composer-prisma-cloud0.35.0 still peers@prisma/orm-postgres8.0.0-rc.20.bun run check:pinsconfirms both.Composer 0.35.0 also addresses a node by its path from the app name, so
dev's endpoint frame for the app service is now named<project>.app. The end-to-end test that waits for that frame now matches the full name. The scaffold itself prints no addresses.The docs for the same release are prisma/web#8649, which describes the scaffold as it is after this PR.
Tests
module.ts, and thatprisma.config.tscontainsentry: "./module.ts".bun run test:unit,bun run check,bun run typecheckandbun run check:pinspass.dev:composerpass. Before the endpoint-name fix, they timed out waiting for the frame. The other 10 end-to-end tests passed in the full run.--no-deploy, built it, and ranprisma dev --detach.prisma dev url <project>.appprinted its URL, and/usersanswered 200.Agent: janeway-45