Repository navigation
ci: type-check, test, build and check the vendored proto on every PR - #67
Merged
Merged
Conversation
The UI had no CI, so nothing guarded pnpm check, pnpm test or pnpm build, and nothing noticed when proto/priompt/v1/prompt.proto drifted from priompt/proto. Refs #49
sujal-maheshwari2004
requested review from
guptadevik2003 and
iamDyeus
as code owners
November 15, 2026 06:17
@types/node was only a transitive dependency (26.2.0), whose stripTypeScriptTypes no longer has mode: 'transform', so svelte-check failed on src/lib/server/api-harness.ts in CI. Local checks passed only because TypeScript picked up an unrelated @types/node from a parent directory. The tests run on Node 24, which still supports 'transform' (strip mode breaks 4 tests), so pin the types to it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #49. The UI had no CI at all.
Two jobs, on pushes to
mainand on every PRnode:pnpm install --frozen-lockfile, thenpnpm check(svelte-check),pnpm testandpnpm build. It uses pnpm 10.27.0 and Node 24, because the test runner needs Node 22.18+.proto: diffs the vendoredproto/priompt/v1/prompt.protoagainst priompt/proto and fails on drift.Left out on purpose (so CI is green from day one; still tracked in #49):
pnpm audit: the lockfile has 7 high advisories until Refresh pnpm-lock.yaml (7 high-severity advisories) and add dependency updates #45 lands.--fail-on-warningsfor svelte-check: there are 11state_referenced_locallywarnings, tracked in Stale editor state after navigation can publish one prompt's text to another #25.Checked locally on
main: install OK, check 0 errors / 11 warnings, test 25/25, build OK, vendored proto identical to priompt/proto.Once this has run on
main,nodeandprotocan be made required checks.Also pins
@types/nodeto^24(the Node version CI runs). It was only a transitive dependency at 26.2.0, wherestripTypeScriptTypeshas nomode: 'transform'any more, sopnpm checkfailed in CI onsrc/lib/server/api-harness.ts. Locally it passed only because TypeScript picked up an unrelated@types/nodefrom a parent directory.'strip'mode would break 4 tests, so the types follow the runtime instead. The lockfile change is limited to@types/nodeandundici-types.