Skip to content

ci: type-check, test, build and check the vendored proto on every PR - #67

Merged
sujal-maheshwari2004 merged 2 commits into
mainfrom
ci/add-workflow
Nov 15, 2026
Merged

sujal-maheshwari2004 merged 2 commits into
mainfrom
ci/add-workflow

Conversation

@sujal-maheshwari2004

@sujal-maheshwari2004 sujal-maheshwari2004 commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

Part of #49. The UI had no CI at all.

Two jobs, on pushes to main and on every PR

  • node: pnpm install --frozen-lockfile, then pnpm check (svelte-check), pnpm test and pnpm build. It uses pnpm 10.27.0 and Node 24, because the test runner needs Node 22.18+.
  • proto: diffs the vendored proto/priompt/v1/prompt.proto against priompt/proto and fails on drift.

Left out on purpose (so CI is green from day one; still tracked in #49):

Checked locally on main: install OK, check 0 errors / 11 warnings, test 25/25, build OK, vendored proto identical to priompt/proto.

Once this has run on main, node and proto can be made required checks.

Also pins @types/node to ^24 (the Node version CI runs). It was only a transitive dependency at 26.2.0, where stripTypeScriptTypes has no mode: 'transform' any more, so pnpm check failed in CI on src/lib/server/api-harness.ts. Locally it passed only because TypeScript picked up an unrelated @types/node from a parent directory. 'strip' mode would break 4 tests, so the types follow the runtime instead. The lockfile change is limited to @types/node and undici-types.

The UI had no CI, so nothing guarded pnpm check, pnpm test or pnpm build, and
nothing noticed when proto/priompt/v1/prompt.proto drifted from priompt/proto.

Refs #49
@types/node was only a transitive dependency (26.2.0), whose
stripTypeScriptTypes no longer has mode: 'transform', so svelte-check failed
on src/lib/server/api-harness.ts in CI. Local checks passed only because
TypeScript picked up an unrelated @types/node from a parent directory. The
tests run on Node 24, which still supports 'transform' (strip mode breaks 4
tests), so pin the types to it.
@sujal-maheshwari2004
sujal-maheshwari2004 merged commit cd42978 into main Nov 15, 2026
2 checks passed
@sujal-maheshwari2004
sujal-maheshwari2004 deleted the ci/add-workflow branch November 15, 2026 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant