Repository navigation
fix(oidc): require an audience and check azp for the OIDC grant - #15
Merged
Merged
Conversation
-oidc-audience defaulted to empty and the aud check was skipped when empty, so with the default config an ID token the tenant's IdP issued to any other application (carrying a groups claim) could be exchanged for a Priompt JWT. serve now refuses -oidc-issuer without -oidc-audience, newIDP rejects an empty audience, aud is always checked, and azp (when present) must equal the audience. README updated.
sujal-maheshwari2004
requested review from
guptadevik2003 and
iamDyeus
as code owners
November 15, 2026 05:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security fix for GHSA-f7hj-cchc-98q8; the advisory is published with the release that contains it. Tested in the advisory's private fork and on current main (go vet, go test).