Repository navigation
fix(authn): stop trusting keys that are removed from the JWKS - #14
Merged
Merged
Conversation
KeySet only ever added keys, so a kid rotated out of /jwks stayed trusted for the life of the process. Rotating a leaked signing key did not take effect until every server restarted. Each successful fetch now replaces the cached key set, and a set older than five minutes is re-fetched in the background (requests keep being served from the cache, and a failed refresh keeps the cached keys and retries after 30s), so a removed key stops verifying within that window.
sujal-maheshwari2004
requested review from
guptadevik2003 and
iamDyeus
as code owners
November 15, 2026 05:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security fix for GHSA-7q3w-26fc-h52h; the advisory is published with the release that contains it. Tested in the advisory's private fork and on current main (go vet, go test).