Conversation
…pilotx-adapter-changes
…/Prebid.js into pilotx-adapter-changes
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a2438d9149
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| payloadItems[placementId]['bidId'] = bidRequest.bidId | ||
| payloadItems[placementId]['gppString'] = gppString | ||
| payloadItems[placementId]['gppApplicableSections'] = applicablesections | ||
| payloadItems[placementId]['uspConsent'] = bidderRequest.uspConsent |
There was a problem hiding this comment.
buildRequests now dereferences bidderRequest.uspConsent unconditionally, while the function still handles bidderRequest as optional elsewhere via optional chaining. If this adapter is invoked without the second argument (common in direct unit/integration calls to adapter specs), it will throw a runtime error before constructing the request payload. Please use a guarded access (for example bidderRequest?.uspConsent) to keep behavior consistent with the new GDPR/GPP handling.
Useful? React with 👍 / 👎.
Coverage Report for CI Build 24422329774Coverage remained the same at 96.365%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
…/Prebid.js into pilotx-adapter-changes
3 participants
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Adding support for other consent information from bidderRequest
Be sure to test the integration with your adserver using the Hello World sample page. -->
Other information