Eliminate SUPERCOP API from tests by willieyz · Pull Request #891 · pq-code-package/mldsa-native

willieyz · 2026-01-16T10:21:01Z

Resolves: Eliminate SUPERCOP API from tests #878
The SUPERCOP API (crypto_sign_*) is a compatibility layer intended for SUPERCOP benchmarking.
Previously, the tests defined a series of SUPERCOP-style names for internal functions (the _internal variants), even though these tests are not part of the standard SUPERCOP API.
Instead of defining SUPERCOP-related macros in every test source file, this commit updates those macros to target the regular mldsa-native API rather than the SUPERCOP compatibility layer.
As a result, the tests invoke the standard API directly while still using macros for name mapping.

Internal functions are now referenced via:

#define keypair_internal MLD_API_NAMESPACE(keypair_internal)

oqs-bot · 2026-01-21T06:47:46Z

CBMC Results (ML-DSA-87)

Full Results (185 proofs)

Proof	Status	Current	Previous	Change
`TOTAL`	✅	2268s	2253s	+0.7%
`sign_verify_internal`	✅	285s	282s	+1%
`polyvecl_pointwise_acc_montgomery_c`	✅	268s	267s	+0%
`polyvec_matrix_expand_eager`	✅	146s	146s	+0%
`rej_uniform_native`	✅	131s	126s	+4%
`poly_pointwise_montgomery_c`	✅	112s	106s	+6%
`mld_invntt_layer`	✅	99s	98s	+1%
`mld_attempt_signature_generation`	✅	85s	84s	+1%
`mld_ct_memcmp`	✅	78s	80s	-3%
`polyvec_matrix_expand_eager_serial`	✅	67s	63s	+6%
`sign_keypair_internal`	✅	48s	50s	-4%
`mld_ntt_layer`	✅	46s	42s	+10%
`fqmul`	✅	29s	29s	+0%
`sign_signature_internal`	✅	26s	24s	+8%
`keccakf1600x4_permute_native`	✅	25s	24s	+4%
`sign_pk_from_sk`	✅	24s	27s	-11%
`polyt0_unpack`	✅	22s	17s	+29%
`rej_uniform`	✅	21s	24s	-12%
`polyveck_sub`	✅	17s	19s	-11%
`mld_ntt_butterfly_block`	✅	16s	16s	+0%
`poly_chknorm_c`	✅	16s	18s	-11%
`polyveck_chknorm`	✅	16s	13s	+23%
`rej_uniform_c`	✅	16s	14s	+14%
`polyveck_decompose`	✅	15s	17s	-12%
`poly_add`	✅	12s	12s	+0%
`poly_uniform_4x`	✅	12s	12s	+0%
`poly_uniform_eta_4x`	✅	12s	14s	-14%
`polyvec_matrix_pointwise_montgomery_eager`	✅	12s	13s	-8%
`polyveck_add`	✅	12s	14s	-14%
`polyvecl_ntt`	✅	12s	10s	+20%
`mld_check_pct`	✅	11s	9s	+22%
`mld_compute_pack_z`	✅	11s	10s	+10%
`poly_invntt_tomont_c`	✅	11s	9s	+22%
`pointwise_acc_native_x86_64`	✅	10s	8s	+25%
`keccak_absorb_once_x4`	✅	9s	9s	+0%
`polyveck_invntt_tomont`	✅	9s	11s	-18%
`polyveck_ntt`	✅	9s	6s	+50%
`keccak_absorb`	✅	8s	7s	+14%
`keccakf1600_permute`	✅	8s	8s	+0%
`sign`	✅	8s	8s	+0%
`keccakf1600_permute_native`	✅	7s	8s	-12%
`mld_sample_s1_s2`	✅	7s	7s	+0%
`pointwise_acc_native_aarch64`	✅	7s	7s	+0%
`poly_decompose_c`	✅	7s	7s	+0%
`polyveck_caddq`	✅	7s	5s	+40%
`polyveck_pointwise_poly_montgomery`	✅	7s	10s	-30%
`polyveck_power2round`	✅	7s	11s	-36%
`polyvecl_pointwise_acc_montgomery_native`	✅	7s	1s	+600%
`sign_open`	✅	7s	4s	+75%
`unpack_sk`	✅	7s	7s	+0%
`poly_ntt_native`	✅	6s	4s	+50%
`poly_power2round`	✅	6s	7s	-14%
`polyeta_unpack`	✅	6s	9s	-33%
`polyt1_unpack`	✅	6s	1s	+500%
`polyveck_reduce`	✅	6s	7s	-14%
`polyveck_use_hint`	✅	6s	7s	-14%
`sign_keypair`	✅	6s	2s	+200%
`unpack_hints`	✅	6s	6s	+0%
`decompose`	✅	5s	2s	+150%
`intt_native_x86_64`	✅	5s	4s	+25%
`mld_ct_cmask_nonzero_u8`	✅	5s	2s	+150%
`mld_sample_s1_s2_serial`	✅	5s	7s	-29%
`pack_sig_c`	✅	5s	2s	+150%
`poly_challenge`	✅	5s	3s	+67%
`poly_shiftl`	✅	5s	4s	+25%
`poly_uniform_gamma1_4x`	✅	5s	5s	+0%
`polyveck_shiftl`	✅	5s	3s	+67%
`polyvecl_chknorm`	✅	5s	3s	+67%
`polyvecl_pointwise_acc_montgomery`	✅	5s	3s	+67%
`polyvecl_uniform_gamma1`	✅	5s	4s	+25%
`polyvecl_uniform_gamma1_serial`	✅	5s	7s	-29%
`polyvecl_unpack_z`	✅	5s	3s	+67%
`rej_eta_native`	✅	5s	4s	+25%
`sign_signature_pre_hash_shake256`	✅	5s	6s	-17%
`sign_verify_pre_hash_shake256`	✅	5s	4s	+25%
`unpack_sig`	✅	5s	3s	+67%
`caddq`	✅	4s	6s	-33%
`keccak_f1600_x4_native_aarch64_v84a`	✅	4s	3s	+33%
`keccakf1600_extract_bytes (big endian)`	✅	4s	2s	+100%
`keccakf1600x4_xor_bytes`	✅	4s	3s	+33%
`mld_value_barrier_u32`	✅	4s	2s	+100%
`pack_sk_rho_key_tr_s2_t0`	✅	4s	4s	+0%
`poly_caddq`	✅	4s	3s	+33%
`poly_decompose`	✅	4s	3s	+33%
`poly_pointwise_montgomery_native`	✅	4s	4s	+0%
`poly_sub`	✅	4s	2s	+100%
`poly_uniform`	✅	4s	4s	+0%
`poly_uniform_gamma1`	✅	4s	2s	+100%
`polyveck_pack_eta`	✅	4s	3s	+33%
`polyveck_unpack_t0`	✅	4s	6s	-33%
`polyz_pack`	✅	4s	3s	+33%
`polyz_unpack`	✅	4s	3s	+33%
`polyz_unpack_c`	✅	4s	4s	+0%
`shake128_finalize`	✅	4s	2s	+100%
`shake128_init`	✅	4s	4s	+0%
`sign_signature_extmu`	✅	4s	6s	-33%
`sign_verify_extmu`	✅	4s	5s	-20%
`keccak_init`	✅	3s	1s	+200%
`keccak_squeeze`	✅	3s	3s	+0%
`keccak_squeezeblocks_x4`	✅	3s	5s	-40%
`keccakf1600_xor_bytes`	✅	3s	2s	+50%
`keccakf1600x4_permute`	✅	3s	1s	+200%
`mld_ct_cmask_nonzero_u32`	✅	3s	5s	-40%
`mld_h`	✅	3s	3s	+0%
`mld_keccakf1600_extract_bytes`	✅	3s	3s	+0%
`mld_value_barrier_i64`	✅	3s	1s	+200%
`ntt_native_aarch64`	✅	3s	4s	-25%
`ntt_native_x86_64`	✅	3s	4s	-25%
`pointwise_native_x86_64`	✅	3s	3s	+0%
`poly_caddq_c`	✅	3s	4s	-25%
`poly_caddq_native_aarch64`	✅	3s	3s	+0%
`poly_ntt`	✅	3s	2s	+50%
`poly_ntt_c`	✅	3s	3s	+0%
`poly_permute_bitrev_to_custom_optional_native`	✅	3s	4s	-25%
`poly_uniform_eta`	✅	3s	3s	+0%
`poly_use_hint_native`	✅	3s	4s	-25%
`polyeta_pack`	✅	3s	3s	+0%
`polyt0_pack`	✅	3s	2s	+50%
`polyveck_pack_t0`	✅	3s	4s	-25%
`polyveck_unpack_eta`	✅	3s	2s	+50%
`polyvecl_pack_eta`	✅	3s	3s	+0%
`polyvecl_unpack_eta`	✅	3s	5s	-40%
`reduce32`	✅	3s	2s	+50%
`rej_eta_c`	✅	3s	5s	-40%
`shake256_finalize`	✅	3s	2s	+50%
`shake256_init`	✅	3s	2s	+50%
`shake256_release`	✅	3s	1s	+200%
`sign_signature`	✅	3s	4s	-25%
`sign_verify`	✅	3s	6s	-50%
`sign_verify_pre_hash_internal`	✅	3s	3s	+0%
`unpack_pk`	✅	3s	4s	-25%
`use_hint`	✅	3s	2s	+50%
`fqscale`	✅	2s	3s	-33%
`keccak_f1600_x1_native_aarch64`	✅	2s	2s	+0%
`keccak_f1600_x1_native_aarch64_v84a`	✅	2s	2s	+0%
`keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid`	✅	2s	4s	-50%
`keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid`	✅	2s	2s	+0%
`keccak_finalize`	✅	2s	2s	+0%
`keccakf1600_xor_bytes (big endian)`	✅	2s	2s	+0%
`keccakf1600x4_extract_bytes`	✅	2s	3s	-33%
`mld_ct_abs_i32`	✅	2s	2s	+0%
`mld_ct_cmask_neg_i32`	✅	2s	2s	+0%
`mld_ct_get_optblocker_i64`	✅	2s	2s	+0%
`mld_ct_get_optblocker_u8`	✅	2s	2s	+0%
`mld_ct_sel_int32`	✅	2s	2s	+0%
`mld_prepare_domain_separation_prefix`	✅	2s	4s	-50%
`montgomery_reduce`	✅	2s	3s	-33%
`pack_pk`	✅	2s	4s	-50%
`pack_sig_h_poly`	✅	2s	5s	-60%
`pack_sig_z`	✅	2s	3s	-33%
`pointwise_native_aarch64`	✅	2s	3s	-33%
`poly_caddq_native`	✅	2s	2s	+0%
`poly_chknorm`	✅	2s	2s	+0%
`poly_chknorm_native`	✅	2s	5s	-60%
`poly_chknorm_native_aarch64`	✅	2s	3s	-33%
`poly_decompose_native`	✅	2s	3s	-33%
`poly_invntt_tomont`	✅	2s	3s	-33%
`poly_invntt_tomont_native`	✅	2s	3s	-33%
`poly_make_hint`	✅	2s	4s	-50%
`poly_permute_bitrev_to_custom_optional`	✅	2s	2s	+0%
`poly_pointwise_montgomery`	✅	2s	3s	-33%
`poly_reduce`	✅	2s	4s	-50%
`polyt1_pack`	✅	2s	1s	+100%
`polyveck_pack_w1`	✅	2s	3s	-33%
`polyw1_pack`	✅	2s	1s	+100%
`polyz_unpack_native`	✅	2s	3s	-33%
`power2round`	✅	2s	2s	+0%
`shake128_release`	✅	2s	3s	-33%
`shake128_squeeze`	✅	2s	1s	+100%
`shake128x4_squeezeblocks`	✅	2s	2s	+0%
`shake256`	✅	2s	4s	-50%
`shake256_absorb`	✅	2s	2s	+0%
`shake256_squeeze`	✅	2s	2s	+0%
`shake256x4_absorb_once`	✅	2s	4s	-50%
`sign_signature_pre_hash_internal`	✅	2s	3s	-33%
`make_hint`	✅	1s	2s	-50%
`mld_ct_get_optblocker_u32`	✅	1s	2s	-50%
`mld_value_barrier_u8`	✅	1s	3s	-67%
`pack_sk_s1`	✅	1s	3s	-67%
`poly_use_hint`	✅	1s	4s	-75%
`poly_use_hint_c`	✅	1s	3s	-67%
`rej_eta`	✅	1s	3s	-67%
`shake128_absorb`	✅	1s	1s	+0%
`shake128x4_absorb_once`	✅	1s	3s	-67%
`shake256x4_squeezeblocks`	✅	1s	2s	-50%
`sys_check_capability`	✅	1s	3s	-67%

oqs-bot · 2026-01-21T06:48:20Z

CBMC Results (ML-DSA-44)

Full Results (185 proofs)

Proof	Status	Current	Previous	Change
`TOTAL`	✅	1803s	1689s	+6.7%
`sign_verify_internal`	✅	234s	220s	+6%
`rej_uniform_native`	✅	129s	116s	+11%
`poly_pointwise_montgomery_c`	✅	117s	102s	+15%
`polyvecl_pointwise_acc_montgomery_c`	✅	114s	100s	+14%
`mld_invntt_layer`	✅	99s	89s	+11%
`mld_ct_memcmp`	✅	81s	75s	+8%
`mld_attempt_signature_generation`	✅	46s	48s	-4%
`mld_ntt_layer`	✅	43s	41s	+5%
`polyvec_matrix_expand_eager`	✅	34s	31s	+10%
`fqmul`	✅	30s	27s	+11%
`keccakf1600x4_permute_native`	✅	24s	24s	+0%
`rej_uniform`	✅	24s	21s	+14%
`sign_keypair_internal`	✅	23s	23s	+0%
`sign_signature_internal`	✅	22s	22s	+0%
`polyt0_unpack`	✅	21s	21s	+0%
`poly_chknorm_c`	✅	20s	17s	+18%
`sign_pk_from_sk`	✅	19s	18s	+6%
`mld_ntt_butterfly_block`	✅	16s	15s	+7%
`polyveck_decompose`	✅	15s	13s	+15%
`rej_uniform_c`	✅	15s	14s	+7%
`poly_uniform_eta_4x`	✅	13s	14s	-7%
`polyvec_matrix_expand_eager_serial`	✅	13s	10s	+30%
`poly_uniform_4x`	✅	12s	11s	+9%
`polyz_unpack_c`	✅	11s	12s	-8%
`mld_check_pct`	✅	10s	9s	+11%
`poly_add`	✅	10s	11s	-9%
`keccakf1600_permute_native`	✅	9s	7s	+29%
`poly_power2round`	✅	9s	8s	+12%
`polyveck_chknorm`	✅	9s	7s	+29%
`keccak_absorb_once_x4`	✅	8s	9s	-11%
`mld_h`	✅	8s	4s	+100%
`polyveck_power2round`	✅	8s	6s	+33%
`keccak_absorb`	✅	7s	7s	+0%
`keccakf1600_permute`	✅	7s	8s	-12%
`mld_compute_pack_z`	✅	7s	7s	+0%
`poly_invntt_tomont_c`	✅	7s	8s	-12%
`poly_use_hint_c`	✅	7s	5s	+40%
`polyvec_matrix_pointwise_montgomery_eager`	✅	7s	7s	+0%
`unpack_sk`	✅	7s	5s	+40%
`pointwise_acc_native_aarch64`	✅	6s	6s	+0%
`pointwise_acc_native_x86_64`	✅	6s	6s	+0%
`poly_caddq_c`	✅	6s	5s	+20%
`poly_caddq_native_aarch64`	✅	6s	4s	+50%
`poly_uniform_eta`	✅	6s	3s	+100%
`polyt0_pack`	✅	6s	5s	+20%
`polyvecl_ntt`	✅	6s	4s	+50%
`shake256x4_absorb_once`	✅	6s	3s	+100%
`sign_keypair`	✅	6s	3s	+100%
`sign_signature_extmu`	✅	6s	4s	+50%
`sign_signature_pre_hash_internal`	✅	6s	5s	+20%
`sign_verify_pre_hash_internal`	✅	6s	4s	+50%
`unpack_hints`	✅	6s	4s	+50%
`keccakf1600_extract_bytes (big endian)`	✅	5s	2s	+150%
`keccakf1600x4_extract_bytes`	✅	5s	2s	+150%
`mld_prepare_domain_separation_prefix`	✅	5s	2s	+150%
`mld_sample_s1_s2`	✅	5s	6s	-17%
`pack_sig_h_poly`	✅	5s	1s	+400%
`poly_challenge`	✅	5s	7s	-29%
`poly_chknorm`	✅	5s	2s	+150%
`poly_invntt_tomont_native`	✅	5s	3s	+67%
`poly_reduce`	✅	5s	3s	+67%
`poly_shiftl`	✅	5s	6s	-17%
`polyeta_unpack`	✅	5s	5s	+0%
`polyveck_ntt`	✅	5s	3s	+67%
`polyveck_reduce`	✅	5s	5s	+0%
`polyveck_shiftl`	✅	5s	5s	+0%
`polyveck_sub`	✅	5s	4s	+25%
`polyvecl_pointwise_acc_montgomery_native`	✅	5s	6s	-17%
`polyvecl_unpack_z`	✅	5s	2s	+150%
`rej_eta_native`	✅	5s	5s	+0%
`sign_verify_pre_hash_shake256`	✅	5s	6s	-17%
`keccak_f1600_x1_native_aarch64`	✅	4s	3s	+33%
`keccak_f1600_x1_native_aarch64_v84a`	✅	4s	2s	+100%
`keccak_finalize`	✅	4s	2s	+100%
`keccak_squeeze`	✅	4s	4s	+0%
`mld_ct_abs_i32`	✅	4s	2s	+100%
`mld_ct_cmask_nonzero_u8`	✅	4s	3s	+33%
`mld_keccakf1600_extract_bytes`	✅	4s	3s	+33%
`mld_sample_s1_s2_serial`	✅	4s	3s	+33%
`mld_value_barrier_u8`	✅	4s	2s	+100%
`montgomery_reduce`	✅	4s	1s	+300%
`ntt_native_aarch64`	✅	4s	3s	+33%
`pack_sig_z`	✅	4s	2s	+100%
`pack_sk_s1`	✅	4s	2s	+100%
`pointwise_native_aarch64`	✅	4s	4s	+0%
`poly_chknorm_native`	✅	4s	3s	+33%
`poly_ntt`	✅	4s	1s	+300%
`poly_ntt_c`	✅	4s	3s	+33%
`poly_permute_bitrev_to_custom_optional_native`	✅	4s	5s	-20%
`poly_uniform`	✅	4s	4s	+0%
`poly_uniform_gamma1`	✅	4s	3s	+33%
`poly_uniform_gamma1_4x`	✅	4s	6s	-33%
`poly_use_hint`	✅	4s	3s	+33%
`polyveck_add`	✅	4s	4s	+0%
`polyveck_caddq`	✅	4s	5s	-20%
`polyveck_pack_t0`	✅	4s	3s	+33%
`polyveck_unpack_eta`	✅	4s	2s	+100%
`polyvecl_unpack_eta`	✅	4s	3s	+33%
`polyw1_pack`	✅	4s	5s	-20%
`rej_eta_c`	✅	4s	4s	+0%
`shake256_init`	✅	4s	2s	+100%
`sign`	✅	4s	5s	-20%
`sign_open`	✅	4s	5s	-20%
`sign_signature_pre_hash_shake256`	✅	4s	6s	-33%
`sign_verify_extmu`	✅	4s	7s	-43%
`unpack_pk`	✅	4s	4s	+0%
`caddq`	✅	3s	4s	-25%
`decompose`	✅	3s	4s	-25%
`fqscale`	✅	3s	3s	+0%
`intt_native_x86_64`	✅	3s	2s	+50%
`keccak_f1600_x4_native_aarch64_v84a`	✅	3s	2s	+50%
`keccak_squeezeblocks_x4`	✅	3s	3s	+0%
`mld_ct_sel_int32`	✅	3s	3s	+0%
`mld_value_barrier_i64`	✅	3s	4s	-25%
`ntt_native_x86_64`	✅	3s	4s	-25%
`pack_pk`	✅	3s	3s	+0%
`poly_caddq_native`	✅	3s	4s	-25%
`poly_chknorm_native_aarch64`	✅	3s	3s	+0%
`poly_decompose`	✅	3s	2s	+50%
`poly_decompose_c`	✅	3s	5s	-40%
`poly_decompose_native`	✅	3s	3s	+0%
`poly_invntt_tomont`	✅	3s	3s	+0%
`poly_permute_bitrev_to_custom_optional`	✅	3s	2s	+50%
`poly_pointwise_montgomery_native`	✅	3s	1s	+200%
`poly_use_hint_native`	✅	3s	2s	+50%
`polyeta_pack`	✅	3s	5s	-40%
`polyveck_pack_w1`	✅	3s	5s	-40%
`polyveck_pointwise_poly_montgomery`	✅	3s	5s	-40%
`polyveck_unpack_t0`	✅	3s	3s	+0%
`polyveck_use_hint`	✅	3s	5s	-40%
`polyvecl_chknorm`	✅	3s	3s	+0%
`polyvecl_pointwise_acc_montgomery`	✅	3s	4s	-25%
`polyvecl_uniform_gamma1_serial`	✅	3s	5s	-40%
`polyz_pack`	✅	3s	3s	+0%
`polyz_unpack`	✅	3s	3s	+0%
`polyz_unpack_native`	✅	3s	3s	+0%
`rej_eta`	✅	3s	3s	+0%
`shake128_absorb`	✅	3s	2s	+50%
`shake128_init`	✅	3s	2s	+50%
`shake128_release`	✅	3s	4s	-25%
`shake128_squeeze`	✅	3s	4s	-25%
`shake128x4_absorb_once`	✅	3s	3s	+0%
`shake256_absorb`	✅	3s	3s	+0%
`shake256_release`	✅	3s	2s	+50%
`shake256_squeeze`	✅	3s	3s	+0%
`shake256x4_squeezeblocks`	✅	3s	2s	+50%
`sign_signature`	✅	3s	3s	+0%
`sign_verify`	✅	3s	4s	-25%
`unpack_sig`	✅	3s	4s	-25%
`use_hint`	✅	3s	2s	+50%
`keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid`	✅	2s	4s	-50%
`keccakf1600_xor_bytes`	✅	2s	3s	-33%
`keccakf1600x4_permute`	✅	2s	4s	-50%
`keccakf1600x4_xor_bytes`	✅	2s	2s	+0%
`mld_ct_cmask_neg_i32`	✅	2s	1s	+100%
`mld_ct_cmask_nonzero_u32`	✅	2s	2s	+0%
`mld_ct_get_optblocker_i64`	✅	2s	2s	+0%
`mld_ct_get_optblocker_u32`	✅	2s	4s	-50%
`mld_ct_get_optblocker_u8`	✅	2s	2s	+0%
`pack_sig_c`	✅	2s	4s	-50%
`pack_sk_rho_key_tr_s2_t0`	✅	2s	3s	-33%
`pointwise_native_x86_64`	✅	2s	4s	-50%
`poly_caddq`	✅	2s	2s	+0%
`poly_make_hint`	✅	2s	3s	-33%
`poly_ntt_native`	✅	2s	3s	-33%
`poly_pointwise_montgomery`	✅	2s	5s	-60%
`poly_sub`	✅	2s	3s	-33%
`polyt1_pack`	✅	2s	2s	+0%
`polyt1_unpack`	✅	2s	3s	-33%
`polyveck_invntt_tomont`	✅	2s	4s	-50%
`polyvecl_pack_eta`	✅	2s	5s	-60%
`polyvecl_uniform_gamma1`	✅	2s	4s	-50%
`reduce32`	✅	2s	3s	-33%
`shake128_finalize`	✅	2s	3s	-33%
`shake128x4_squeezeblocks`	✅	2s	5s	-60%
`shake256`	✅	2s	3s	-33%
`shake256_finalize`	✅	2s	1s	+100%
`sys_check_capability`	✅	2s	2s	+0%
`keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid`	✅	1s	3s	-67%
`keccak_init`	✅	1s	2s	-50%
`keccakf1600_xor_bytes (big endian)`	✅	1s	3s	-67%
`make_hint`	✅	1s	2s	-50%
`mld_value_barrier_u32`	✅	1s	1s	+0%
`polyveck_pack_eta`	✅	1s	4s	-75%
`power2round`	✅	1s	4s	-75%

oqs-bot · 2026-01-21T06:48:28Z

CBMC Results (ML-DSA-65)

Full Results (185 proofs)

Proof	Status	Current	Previous	Change
`TOTAL`	✅	2116s	2008s	+5.4%
`polyvecl_pointwise_acc_montgomery_c`	✅	242s	220s	+10%
`sign_verify_internal`	✅	237s	219s	+8%
`polyvec_matrix_expand_eager`	✅	177s	168s	+5%
`rej_uniform_native`	✅	125s	117s	+7%
`poly_pointwise_montgomery_c`	✅	106s	99s	+7%
`mld_invntt_layer`	✅	97s	94s	+3%
`mld_ct_memcmp`	✅	80s	74s	+8%
`mld_attempt_signature_generation`	✅	51s	49s	+4%
`mld_ntt_layer`	✅	44s	41s	+7%
`fqmul`	✅	30s	28s	+7%
`sign_signature_internal`	✅	30s	26s	+15%
`sign_keypair_internal`	✅	29s	28s	+4%
`keccakf1600x4_permute_native`	✅	27s	24s	+12%
`polyvec_matrix_expand_eager_serial`	✅	27s	27s	+0%
`rej_uniform`	✅	24s	20s	+20%
`sign_pk_from_sk`	✅	22s	19s	+16%
`polyt0_unpack`	✅	20s	17s	+18%
`poly_chknorm_c`	✅	19s	17s	+12%
`polyveck_pointwise_poly_montgomery`	✅	17s	15s	+13%
`mld_ntt_butterfly_block`	✅	16s	19s	-16%
`polyveck_decompose`	✅	15s	15s	+0%
`rej_uniform_c`	✅	15s	13s	+15%
`polyveck_power2round`	✅	14s	14s	+0%
`poly_uniform_4x`	✅	13s	11s	+18%
`poly_uniform_eta_4x`	✅	13s	12s	+8%
`polyveck_add`	✅	13s	12s	+8%
`poly_add`	✅	12s	12s	+0%
`polyvec_matrix_pointwise_montgomery_eager`	✅	10s	9s	+11%
`polyz_unpack_c`	✅	10s	11s	-9%
`pointwise_acc_native_x86_64`	✅	9s	4s	+125%
`keccak_absorb`	✅	8s	7s	+14%
`keccak_absorb_once_x4`	✅	8s	10s	-20%
`keccakf1600_permute_native`	✅	8s	8s	+0%
`mld_sample_s1_s2`	✅	8s	8s	+0%
`polyveck_caddq`	✅	8s	7s	+14%
`sign`	✅	8s	7s	+14%
`mld_check_pct`	✅	7s	10s	-30%
`mld_compute_pack_z`	✅	7s	4s	+75%
`poly_invntt_tomont_c`	✅	7s	8s	-12%
`polyveck_invntt_tomont`	✅	7s	6s	+17%
`polyveck_ntt`	✅	7s	7s	+0%
`polyveck_reduce`	✅	7s	8s	-12%
`polyveck_sub`	✅	7s	6s	+17%
`polyveck_use_hint`	✅	7s	8s	-12%
`polyvecl_ntt`	✅	7s	8s	-12%
`caddq`	✅	6s	4s	+50%
`keccak_squeezeblocks_x4`	✅	6s	6s	+0%
`keccakf1600_permute`	✅	6s	8s	-25%
`mld_sample_s1_s2_serial`	✅	6s	5s	+20%
`pointwise_acc_native_aarch64`	✅	6s	5s	+20%
`poly_power2round`	✅	6s	5s	+20%
`polyvecl_chknorm`	✅	6s	3s	+100%
`sign_signature`	✅	6s	3s	+100%
`sign_signature_extmu`	✅	6s	7s	-14%
`mld_ct_get_optblocker_u32`	✅	5s	2s	+150%
`poly_caddq_c`	✅	5s	3s	+67%
`poly_challenge`	✅	5s	3s	+67%
`poly_chknorm`	✅	5s	2s	+150%
`poly_decompose_c`	✅	5s	4s	+25%
`poly_invntt_tomont_native`	✅	5s	4s	+25%
`poly_ntt`	✅	5s	2s	+150%
`poly_shiftl`	✅	5s	4s	+25%
`poly_sub`	✅	5s	2s	+150%
`polyt0_pack`	✅	5s	4s	+25%
`polyveck_chknorm`	✅	5s	6s	-17%
`polyveck_shiftl`	✅	5s	7s	-29%
`rej_eta`	✅	5s	2s	+150%
`rej_eta_c`	✅	5s	2s	+150%
`shake256`	✅	5s	3s	+67%
`sign_keypair`	✅	5s	3s	+67%
`sign_verify_extmu`	✅	5s	5s	+0%
`sign_verify_pre_hash_internal`	✅	5s	6s	-17%
`sys_check_capability`	✅	5s	1s	+400%
`unpack_hints`	✅	5s	6s	-17%
`keccak_f1600_x1_native_aarch64_v84a`	✅	4s	2s	+100%
`keccak_finalize`	✅	4s	5s	-20%
`keccakf1600_extract_bytes (big endian)`	✅	4s	3s	+33%
`keccakf1600_xor_bytes`	✅	4s	1s	+300%
`make_hint`	✅	4s	3s	+33%
`mld_ct_get_optblocker_i64`	✅	4s	3s	+33%
`pointwise_native_aarch64`	✅	4s	4s	+0%
`pointwise_native_x86_64`	✅	4s	4s	+0%
`poly_caddq`	✅	4s	6s	-33%
`poly_ntt_c`	✅	4s	3s	+33%
`poly_uniform_gamma1`	✅	4s	3s	+33%
`polyeta_pack`	✅	4s	3s	+33%
`polyeta_unpack`	✅	4s	4s	+0%
`polyt1_unpack`	✅	4s	1s	+300%
`polyvecl_pack_eta`	✅	4s	3s	+33%
`polyw1_pack`	✅	4s	2s	+100%
`shake128x4_absorb_once`	✅	4s	1s	+300%
`shake256_absorb`	✅	4s	2s	+100%
`shake256x4_absorb_once`	✅	4s	5s	-20%
`sign_open`	✅	4s	4s	+0%
`sign_signature_pre_hash_internal`	✅	4s	8s	-50%
`sign_verify`	✅	4s	5s	-20%
`unpack_sk`	✅	4s	4s	+0%
`decompose`	✅	3s	1s	+200%
`intt_native_x86_64`	✅	3s	2s	+50%
`keccak_f1600_x4_native_aarch64_v8a_scalar_hybrid`	✅	3s	1s	+200%
`keccak_f1600_x4_native_aarch64_v8a_v84a_scalar_hybrid`	✅	3s	4s	-25%
`keccak_init`	✅	3s	3s	+0%
`keccakf1600x4_permute`	✅	3s	3s	+0%
`keccakf1600x4_xor_bytes`	✅	3s	2s	+50%
`mld_ct_cmask_neg_i32`	✅	3s	2s	+50%
`mld_ct_get_optblocker_u8`	✅	3s	3s	+0%
`mld_keccakf1600_extract_bytes`	✅	3s	3s	+0%
`mld_value_barrier_i64`	✅	3s	2s	+50%
`ntt_native_aarch64`	✅	3s	2s	+50%
`ntt_native_x86_64`	✅	3s	3s	+0%
`pack_pk`	✅	3s	6s	-50%
`pack_sig_h_poly`	✅	3s	2s	+50%
`poly_caddq_native_aarch64`	✅	3s	3s	+0%
`poly_chknorm_native`	✅	3s	4s	-25%
`poly_decompose`	✅	3s	3s	+0%
`poly_decompose_native`	✅	3s	5s	-40%
`poly_make_hint`	✅	3s	3s	+0%
`poly_uniform`	✅	3s	8s	-62%
`poly_uniform_eta`	✅	3s	3s	+0%
`poly_uniform_gamma1_4x`	✅	3s	1s	+200%
`poly_use_hint`	✅	3s	2s	+50%
`poly_use_hint_c`	✅	3s	4s	-25%
`poly_use_hint_native`	✅	3s	1s	+200%
`polyveck_pack_t0`	✅	3s	2s	+50%
`polyveck_pack_w1`	✅	3s	2s	+50%
`polyveck_unpack_eta`	✅	3s	2s	+50%
`polyvecl_uniform_gamma1`	✅	3s	5s	-40%
`polyvecl_uniform_gamma1_serial`	✅	3s	4s	-25%
`polyvecl_unpack_eta`	✅	3s	2s	+50%
`polyz_pack`	✅	3s	2s	+50%
`polyz_unpack`	✅	3s	4s	-25%
`polyz_unpack_native`	✅	3s	2s	+50%
`power2round`	✅	3s	5s	-40%
`rej_eta_native`	✅	3s	3s	+0%
`shake128_absorb`	✅	3s	2s	+50%
`shake128x4_squeezeblocks`	✅	3s	2s	+50%
`shake256_finalize`	✅	3s	3s	+0%
`shake256_init`	✅	3s	4s	-25%
`shake256x4_squeezeblocks`	✅	3s	2s	+50%
`sign_signature_pre_hash_shake256`	✅	3s	4s	-25%
`sign_verify_pre_hash_shake256`	✅	3s	3s	+0%
`unpack_pk`	✅	3s	4s	-25%
`unpack_sig`	✅	3s	4s	-25%
`use_hint`	✅	3s	4s	-25%
`fqscale`	✅	2s	3s	-33%
`keccak_f1600_x4_native_aarch64_v84a`	✅	2s	3s	-33%
`keccakf1600_xor_bytes (big endian)`	✅	2s	3s	-33%
`keccakf1600x4_extract_bytes`	✅	2s	1s	+100%
`mld_ct_cmask_nonzero_u32`	✅	2s	4s	-50%
`mld_ct_cmask_nonzero_u8`	✅	2s	2s	+0%
`mld_ct_sel_int32`	✅	2s	3s	-33%
`mld_h`	✅	2s	2s	+0%
`mld_prepare_domain_separation_prefix`	✅	2s	5s	-60%
`mld_value_barrier_u32`	✅	2s	4s	-50%
`montgomery_reduce`	✅	2s	3s	-33%
`pack_sig_c`	✅	2s	3s	-33%
`pack_sig_z`	✅	2s	4s	-50%
`pack_sk_rho_key_tr_s2_t0`	✅	2s	2s	+0%
`pack_sk_s1`	✅	2s	3s	-33%
`poly_caddq_native`	✅	2s	3s	-33%
`poly_chknorm_native_aarch64`	✅	2s	2s	+0%
`poly_ntt_native`	✅	2s	4s	-50%
`poly_permute_bitrev_to_custom_optional`	✅	2s	3s	-33%
`poly_permute_bitrev_to_custom_optional_native`	✅	2s	2s	+0%
`poly_pointwise_montgomery`	✅	2s	2s	+0%
`poly_pointwise_montgomery_native`	✅	2s	2s	+0%
`polyt1_pack`	✅	2s	2s	+0%
`polyveck_pack_eta`	✅	2s	4s	-50%
`polyveck_unpack_t0`	✅	2s	5s	-60%
`polyvecl_pointwise_acc_montgomery`	✅	2s	3s	-33%
`polyvecl_pointwise_acc_montgomery_native`	✅	2s	6s	-67%
`reduce32`	✅	2s	2s	+0%
`shake128_finalize`	✅	2s	3s	-33%
`shake128_init`	✅	2s	4s	-50%
`shake128_release`	✅	2s	3s	-33%
`shake128_squeeze`	✅	2s	2s	+0%
`shake256_release`	✅	2s	2s	+0%
`keccak_f1600_x1_native_aarch64`	✅	1s	5s	-80%
`keccak_squeeze`	✅	1s	2s	-50%
`mld_ct_abs_i32`	✅	1s	4s	-75%
`mld_value_barrier_u8`	✅	1s	2s	-50%
`poly_invntt_tomont`	✅	1s	2s	-50%
`poly_reduce`	✅	1s	3s	-67%
`polyvecl_unpack_z`	✅	1s	6s	-83%
`shake256_squeeze`	✅	1s	2s	-50%

mkannwischer

Thanks @willieyz.

You forgot to modify test_stack.c and test_rng_fail.c. In the files you changes you forgot a lot of functions.

mkannwischer · 2026-01-26T00:55:27Z

Still using the SUPERCOP API.

mkannwischer · 2026-01-26T00:56:02Z

still using the SUPERCOP API.

mkannwischer · 2026-01-26T00:56:08Z

mkannwischer · 2026-01-26T00:56:33Z

still using the SUPERCOP API

mkannwischer · 2026-01-26T00:57:04Z

Using the SUPERCOP API in 25 places....

mkannwischer · 2026-04-02T07:41:40Z

@willieyz, can you please rebase this and get it through CI and mark it as ready when it is. Thanks!

The SUPERCOP API (crypto_sign_*) is a compatibility layer intended for SUPERCOP benchmarking. Previously, the tests defined a series of SUPERCOP-style names for internal functions (the _internal variants), even though these tests are not part of the standard SUPERCOP API. Instead of defining SUPERCOP-related macros in every test source file, switch the tests to the regular mld API naming while keeping the existing pattern of local aliases in each file. Signed-off-by: willieyz <willie.zhao@chelpis.com>

mkannwischer · 2026-06-30T14:09:52Z

Superseded by Remove crypto_sign_* API aliases and MLD_CONFIG_NO_SUPERCOP #1248.

willieyz force-pushed the eliminate-supercopAPI branch 8 times, most recently from da6eebe to afc1cf6 Compare January 21, 2026 06:30

willieyz marked this pull request as ready for review January 21, 2026 07:10

willieyz requested a review from a team as a code owner January 21, 2026 07:10

mkannwischer requested changes Jan 26, 2026

View reviewed changes

willieyz force-pushed the eliminate-supercopAPI branch 5 times, most recently from b4779ed to 50b94dd Compare January 29, 2026 05:51

mkannwischer marked this pull request as draft April 2, 2026 07:41

willieyz force-pushed the eliminate-supercopAPI branch 4 times, most recently from 23f86ca to e909098 Compare April 6, 2026 09:57

willieyz force-pushed the eliminate-supercopAPI branch 5 times, most recently from 1fd10ac to 26f049a Compare April 23, 2026 04:25

willieyz force-pushed the eliminate-supercopAPI branch from 26f049a to 8c881ce Compare April 23, 2026 08:50

willieyz requested a review from mkannwischer April 23, 2026 08:55

willieyz marked this pull request as ready for review April 23, 2026 08:55

mkannwischer closed this Jun 30, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Eliminate SUPERCOP API from tests#891

Eliminate SUPERCOP API from tests#891
willieyz wants to merge 1 commit into
mainfrom
eliminate-supercopAPI

willieyz commented Jan 16, 2026 •

edited

Loading

Uh oh!

oqs-bot commented Jan 21, 2026 •

edited

Loading

Uh oh!

oqs-bot commented Jan 21, 2026 •

edited

Loading

Uh oh!

oqs-bot commented Jan 21, 2026 •

edited

Loading

Uh oh!

mkannwischer left a comment

Uh oh!

mkannwischer Jan 26, 2026

Uh oh!

mkannwischer Jan 26, 2026

Uh oh!

mkannwischer Jan 26, 2026

Uh oh!

mkannwischer Jan 26, 2026

Uh oh!

mkannwischer Jan 26, 2026

Uh oh!

mkannwischer commented Apr 2, 2026

Uh oh!

mkannwischer commented Jun 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

willieyz commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

oqs-bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CBMC Results (ML-DSA-87)

Uh oh!

oqs-bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CBMC Results (ML-DSA-44)

Uh oh!

oqs-bot commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CBMC Results (ML-DSA-65)

Uh oh!

mkannwischer left a comment

Choose a reason for hiding this comment

Uh oh!

mkannwischer Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

mkannwischer Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

mkannwischer Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

mkannwischer Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

mkannwischer Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

mkannwischer commented Apr 2, 2026

Uh oh!

mkannwischer commented Jun 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

willieyz commented Jan 16, 2026 •

edited

Loading

oqs-bot commented Jan 21, 2026 •

edited

Loading

oqs-bot commented Jan 21, 2026 •

edited

Loading

oqs-bot commented Jan 21, 2026 •

edited

Loading