Add missing MLD_INTERNAL_API/MLD_EXTERNAL_API declarations#1288
Open
hanno-becker wants to merge 1 commit into
Open
Add missing MLD_INTERNAL_API/MLD_EXTERNAL_API declarations#1288hanno-becker wants to merge 1 commit into
hanno-becker wants to merge 1 commit into
Conversation
Annotate mld_polyeta_unpack and mld_prepare_domain_separation_prefix. Extracted from #1052. Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
Contributor
CBMC Results (ML-DSA-87, REDUCE-RAM)Full Results (209 proofs)
|
Contributor
CBMC Results (ML-DSA-65, REDUCE-RAM)Full Results (209 proofs)
|
Contributor
CBMC Results (ML-DSA-44)Full Results (209 proofs)
|
Contributor
CBMC Results (ML-DSA-44, REDUCE-RAM)Full Results (209 proofs)
|
Contributor
CBMC Results (ML-DSA-65)Full Results (209 proofs)
|
Contributor
CBMC Results (ML-DSA-87)
Full Results (209 proofs)
|
mkannwischer
requested changes
Jul 16, 2026
mkannwischer
left a comment
Contributor
There was a problem hiding this comment.
Should mld_keccak_f1600_x4_native_impl also be marked as internal?
(same applies to the avx2 intrinsics, but those are going to be removed shortly anyway).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annotate mld_polyeta_unpack and mld_prepare_domain_separation_prefix.