Repository navigation
Keep repair-sweep tests from outgrowing the lane hang timeout - #2142
Merged
Merged
Conversation
…eout The stranded-binding repair builds one query across every group of interchangeable provider connections in the database, on each candidate it attempts. Every sibling-connection test leaves a group behind, so late in the Integration lane a pass took ~70s and the refused-candidates test, which needs four passes of four attempts, ran past --blame-hang-timeout. Retire the sibling connections earlier tests left before the tests that sweep repeatedly, and fail their waits with a named timeout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--blame-hang-timeout 5minsideSameHostConnectionsFlowTests.Credentials_whose_repositories_their_successors_connection_cannot_take_do_not_keep_a_repairable_one_waiting. The stranded-binding repair (CredentialSuccessionService.StrandedWithSuccessorAsync) unions one query per group of interchangeable connections in the whole database, for both the page load and the per-candidate verdict. Each sibling-connection test leaves a group behind, so pass time grew through the lane (3s, 6s, 9s, then ~70s per pass in the failing runs); that test needs four passes of four attempts and ran past 5 minutes.BindingMoveKit.RetireOtherSiblingConnectionsAsyncsoft-deletes sibling connections left by earlier tests (never the kit's own); the sweeping tests call it first. Their wait loops now throw aTimeoutExceptionafter 2 minutes naming the watched signal and where to look.Test plan