Repository navigation
fix: bound unclosed comment source positions to input - #48
Merged
Merged
Conversation
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing an unfinished comment such as
/*aputs its source end offset at 4 even though the original input has only 3 characters. The root end is also beyond EOF. This happens because the fault-tolerant tokenizer can advance past the input andInput.fromOffset()returns a location even for that offset.Clamp the comment end to the last original character and the root end to EOF. Preserve the usual convention: comment line/column identify its last character, while the offset is exclusive. Add a multiline unfinished-comment regression covering both source ranges and extraction of the original comment text.
Validation: the new regression fails before the fix; all 49 unit tests pass after it.
npm run test:lintandnpm run test:integrationpass (33 real-world resources).