Repository navigation
fix(parser): parse digit-led atoms that are not sequence sets as ATOM - #12
Merged
Merged
Conversation
A token made of digits, ":", "," and "*" that is not a valid sequence set, like "10:" or "12:30:00", is a valid atom (RFC 3501 section 9), so it is returned as an ATOM instead of throwing. Commands that take a sequence set validate ATOM values themselves. Fixes #11 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tokens like
10:or12:30:00are valid atoms (RFC 3501 section 9,:and,are ATOM-CHARs), so the parser returns them asATOMinstead of throwingInvalid sequence set. Commands that take a sequence set validate ATOM values themselves (ImapKit already does ingetMessageRange).Fixes #11
🤖 Generated with Claude Code