Implement package layering refactor (Phases 1-2)

[bschwedler]

Break circular dependencies in posit-bakery by splitting config layer into separate build, targets, and registry management packages.

Phase 1: Extract build execution and registry cleanup from BakeryConfig into dedicated build/ and registry_management/ packages. Moves build_targets, bake_plan_json, metadata loading/merging, clean_caches, and clean_temporary out of config layer.

Phase 2: Extract target selection logic into targets/ package. Consolidates duplicate filtering logic from cli/ci.py::matrix with BakeryConfig.generate_image_targets into a single select_targets function. Moves BakerySettings and BakeryConfigFilter to config/settings.py.

Result: config/ no longer imports image, parallel, or registry_management. The BakeryConfig.targets compatibility property was removed to avoid recreating the config → targets → image → config cycle; callers now select targets explicitly with targets.select_targets(config, settings).

Dependency rule after split:

• cli, plugins → build, targets, registry_management, config, image, parallel
• build → targets, image, parallel, config
• targets → config, image
• registry_management → image
• image → config, parallel
• config → config, const, error, util, settings

Plan: package-layering.md

Related issue:

• Split BakeryConfig into a document model, CRUD manager, and build service #593

[github-actions]

Test Results

2 339 tests  +4   2 339 ✅ +4   9m 5s ⏱️ + 1m 22s
    1 suites ±0       0 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 367b368. ± Comparison against base commit 2a5bc5a.

♻️ This comment has been updated with latest results.

[bschwedler]

Package dependencies after the split:

flowchart LR
  cli <--> plugins
  cli --> build & targets & registry_management
  plugins --> build & targets
  build --> image
  targets --> image
  registry_management --> image
  image --> config & parallel

Loading

Edges implied by a longer path are omitted (e.g. cli → config). config no longer imports image, parallel, or registry_management, which breaks the config ↔ image cycle. The cli ↔ plugins cycle predates this PR: cli loads plugins through plugins.registry, and plugins import shared CLI helpers from cli.common.

[bschwedler]

Moved functions

Paths are relative to posit_bakery/.

config/config.py → build/runner.py

# before
def BakeryConfig.build_targets(
    self,
    load: bool = True,
    push: bool = False,
    pull: bool = False,
    cache: bool = True,
    platforms: list[str] | None = None,
    strategy: ImageBuildStrategy = ImageBuildStrategy.BAKE,
    metadata_file: Path | None = None,
    fail_fast: bool = False,
    retry: int = 0,
    jobs: int | None = None,
)

# after
def build_targets(
    base_path: Path,
    targets: list[ImageTarget],
    temp_registry: str | None,
    clean_temporary: bool,
    load: bool = True,
    push: bool = False,
    pull: bool = False,
    cache: bool = True,
    platforms: list[str] | None = None,
    strategy: ImageBuildStrategy = ImageBuildStrategy.BAKE,
    metadata_file: Path | None = None,
    fail_fast: bool = False,
    retry: int = 0,
    jobs: int | None = None,
) -> BuildResult

config/config.py → build/runner.py (renamed)

# before
def BakeryConfig.bake_plan_targets(self, push: bool = False) -> str

# after
def bake_plan_json(
    base_path: Path, targets: list[ImageTarget], push: bool = False
) -> str

config/config.py → build/runner.py

# before
def BakeryConfig.load_build_metadata_from_file(
    self, metadata_file: Path
) -> list[str]

# after
def load_build_metadata_from_file(
    targets: list[ImageTarget], metadata_file: Path
) -> list[str]

config/config.py → build/runner.py

# before
def BakeryConfig._merge_sequential_build_metadata_files(
    self,
) -> dict[str, Any]

# after
def _merge_sequential_build_metadata_files(
    targets: list[ImageTarget],
) -> dict[str, Any]

config/config.py → registry_management/clean.py

clean_temporary has the same signature change.

# before
def BakeryConfig.clean_caches(
    self,
    remove_untagged: bool = True,
    remove_older_than: timedelta | None = None,
    dry_run: bool = False,
)

# after
def clean_caches(
    targets: list[ImageTarget],
    remove_untagged: bool = True,
    remove_older_than: timedelta | None = None,
    dry_run: bool = False,
) -> list[Exception]

config/config.py → targets/selection.py (renamed)

# before
def BakeryConfig.generate_image_targets(
    self, settings: BakerySettings = BakerySettings()
)

# after
def select_targets(
    config: "BakeryConfig", settings: BakerySettings, *, sort: bool = True
) -> list[ImageTarget]

cli/common.py → targets/selection.py

# before
def exit_if_no_targets(config: "BakeryConfig", settings: "BakerySettings") -> None

# after
def exit_if_no_targets(
    targets: list[ImageTarget], settings: BakerySettings, context: str = "build"
) -> None

(new) → targets/ci_matrix.py

# before: inline loop in the `ci matrix` command, no function

# after
def matrix_rows(
    targets: list[ImageTarget], exclude: list[BakeryCIMatrixFieldEnum] | None = None
) -> list[dict[str, str | bool]]

config/config.py → deleted

# before
def BakeryConfig.get_image_target_by_uid(
    self, uid: str
) -> ImageTarget | None

# after: removed; publish() now filters select_targets() output by UID

Moved with no signature change

• _retry_build: config/config.py → build/runner.py
• apply_recent_versions: config/config.py → targets/selection.py (type hints now quoted)
• _describe_active_filters: cli/common.py → targets/selection.py
• version_matches: config/config.py → config/image/parsed_version.py
• BakerySettings.dev_stream, .effective_dev_channel, .migrate_dev_stream_to_dev_channel: BakerySettings moved from config/config.py → config/settings.py

[ianpittwood]

The bulk of this looks good, just a few things we may want to address.

[ianpittwood]

I think there's some risk with the else None fallback. I don't see any filtering done later in this logic so there's an opportunity for a TypeError at REGISTRY_PATTERN.match() calls.

[bschwedler]

I factored this out to a helper for easier cognition and exception handling:

images-shared/posit-bakery/posit_bakery/registry_management/clean.py

Lines 39 to 45 in 367b368

	def _cache_registry_name(target: ImageTarget) -> str | None:
	"""Return the registry from a target's cache name, if it has one."""
	cache_name = target.cache_name()
	if not cache_name:
	return None
	return cache_name.split(":", maxsplit=1)[0]