Repository navigation
Conversation
Track QUALIFY filters and rowset sources
Contributor
Author
|
oops, sorry, not yet ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promote the completed
pre_66stack intopondpilot/flowscope:master.This PR consolidates the investigation-driven fixes for the MSSQL/Synapse corpus and preserves diagnostic metadata across the core, CLI, WASM, and report-export boundaries.
Changes
MSSQL and SQL analysis
GObatch separators.GO.QUALIFYpredicates as structuredQUALIFYfilters.OPENJSONandXMLTABLEtable factors in the legacy extractor.Diagnostics and metadata
AnalyzeResultstatement identity.WASM and exports
projectNameandexportedAtfields.Issuesworksheet to XLSX exports while preserving existing worksheet names and order.Deliberate scope boundaries
OPENROWSETgrammar is not claimed here;sqlparserstill needs dedicated upstream grammar/AST support for the documented forms.synapsedialect is introduced; Synapse-compatible syntax remains under the existing MSSQL dialect.PIVOT/UNPIVOTgenerated-column semantics, dynamicEXECUTElineage, and complete external-rowset schema inference remain follow-up work.Validation
Focused validation completed during the stack:
cargo fmt --allcargo test --locked -p flowscope-core --test schema_guard api_schema_snapshot_matches -- --nocapturecargo test --locked -p flowscope-core --test lineage_engine snowflake_qualify_clause_filters_window_results -- --nocapturecargo test --locked -p flowscope-core --test lineage_engine openjson_table_factor_sql_server -- --nocapturecargo test --locked -p flowscope-core --lib extractors::tests -- --nocapturecargo test --locked -p flowscope-export --test export_formats --no-default-featurescargo test --locked -p flowscope-wasm --test analysis -- --nocaptureThe browser WASM harness was added but not run in the development container because Chromium/wasm-pack were unavailable. CI should run the normal workspace checks before merge.
Fixes #68