Repository navigation
Fix file save, loading and tab bugs from a code review - #195
Merged
Merged
Conversation
The reader also accepts the old 7 digit name.
Invalid values show an error instead of throwing.
A short last chunk and records with no frames are written back as loaded.
Close the old skills file on reload.
Rows that are not numbers are skipped instead of setting id 0.
Row offsets are written as ushort, without the unused padding after the table.
Entries too short for a palette load as empty instead of decoding stale bytes.
Replace from folder inserts into the tile list instead of overwriting the next id.
Marks hues as changed and refreshes other tabs.
CSV import keeps text that contains ';'.
Show the first entry's frames after load; cap frames at 64 and offsets at a signed byte.
Missing or invalid values keep their defaults instead of stopping startup.
Unsubscribe in Unload.
Instances made only for the list are dropped on close and never unloaded.
A cross-tab Select before the tab was opened listed every tile twice.
Moves and removes ignore tiles no longer in the multi; Z is clamped to a signed byte on add.
Missing attributes no longer stop the load.
Later chunks keep their place instead of shifting.
Jumping back in the undo list keeps the skipped states for redo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File saving:
Loading and reading:
Tabs:
App and plugins: