Repository navigation
Fix GIF animation import colors, empty frames and palettes - #190
Merged
Merged
Conversation
Convert each GIF frame instead of a blank bitmap, and keep all frames of the GIF instead of a one-frame copy.
Match background colours on the source colour, not after the drop to 5 bits, which made pixels of 248-255 white (and 168-175 grey in CV5/KR) transparent.
Adding or replacing frames fits the palette to their colours, reducing past 256 and mapping to the nearest colour instead of index 0; existing frames keep their colours.
Without transparency the background came out black and re-imported as a black box; import removes white.
Images named ..._{direction}_{frame} are sorted into directions and frames; each frame keeps the
center of the frame it replaces. Five GIFs work as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
..._{direction}_{frame}) and replaces its frames, keeping each frame's center.Closes #45
Closes #28