Skip to content

fix: deduplicate resource creation and preserve RPC state #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lojhan merged 2 commits into from
Oct 22, 2026
Merged

fix: deduplicate resource creation and preserve RPC state #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e55182d
fix: deduplicate resource creation and preserve RPC state
Lojhan Oct 22, 2026
063b18c
test: infer resource module paths in ESM fixtures
Lojhan Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/resource-registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
export class ResourceRegistry<T> {
private registry: Record<string, T> = Object.create(null);
private isRegistering = false;
private registeringDepth = 0;

register(name: string, entry: T) {
this.registry[name] = entry;
Expand All @@ -18,14 +18,19 @@ export class ResourceRegistry<T> {
for (const key in this.registry)
if (Object.prototype.hasOwnProperty.call(this.registry, key))
delete this.registry[key];
this.registeringDepth = 0;
}

getIsRegistering() {
return this.isRegistering;
return this.registeringDepth > 0;
}

setIsRegistering(value: boolean) {
this.isRegistering = value;
if (value) {
this.registeringDepth++;
} else {
this.registeringDepth = Math.max(0, this.registeringDepth - 1);
}
}

getRegistry() {
Expand Down
Loading
Loading