Repository navigation
fix: stabilize scoped React rendering across runtimes - #29
Merged
Merged
Conversation
Lojhan
marked this pull request as draft
October 22, 2026 13:10
wellwelwel
reviewed
Oct 22, 2026
Comment on lines
+30
to
+35
| // Lazily load `react-dom/client` on first `render()` call rather than at module | ||
| // import time. If a user imports `reactTestingPlugin` from the `@pokujs/react` | ||
| // barrel inside `poku.config.js` under `isolation: 'none'`, the config module is | ||
| // evaluated before `plugin.setup()` installs `window` and `document`. Eagerly | ||
| // importing `react-dom/client` before `window` exists causes React DOM to cache | ||
| // `canUseDOM = false` and permanently disable its synthetic event system. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use shared scoped registries and testing helpers, load React DOM after environment setup, and preserve live hook results and primitive props. Require the published @pokujs/dom ^1.3.2 helpers and keep DOM as a production dependency. Run the jsdom suite in separate processes so React 18 does not reuse its cached happy-dom document.
Validated locally: typecheck, build, format checks, and the React 18 regression. CI covers Node 20/22/24, Bun, Deno, React 18/19, build, lint, and CodeQL.
The DOM dependency is released: https://github.com/pokujs/dom/releases/tag/dom-v1.3.2.