Resolve untargeted PoE2 references in PassiveSkills, NPCTalk, CharacterStartStates and AfflictionQuestFogBankValues - #248
Closed
juddisjudd wants to merge 1 commit into
Closed
juddisjudd wants to merge 1 commit into
juddisjudd wants to merge 1 commit into
Conversation
PassiveSkills gains VariantType: PassiveSkillVariantTypes, NPCTalk a Characters list, CharacterStartStates a SupportGems list, and the four rid columns of AfflictionQuestFogBankValues point at NPCs. Each target was confirmed by reading the referenced rows on patch 4.5.5.2.
Contributor
Author
|
Superseded by #249, which carries both changes in a single commit on top of main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves nine
ridcolumns in PoE2 tables to the tables they actually reference. Each one was found by ranking candidate tables by row count against the column's index range, then confirmed by reading the referenced rows.PassiveSkills
_: rid→VariantType: PassiveSkillVariantTypes(85 rows, 84 referenced). For every atlas notable the referenced row'sIdis the passive's ownId(AtlasStrongboxNotable10→AtlasStrongboxNotable10,AtlasBreachNotable13→AtlasBreachNotable13, …), and the 583 attribute passives all point atGenericAttribute.NPCTalk
_: [rid]→Characters: [Characters](12 rows, all 12 referenced). Set on 19 rows and gates dialogue by class:Monk RevealandArchon of Chayulalist one character,IntroductionandWho Are You?list every character. It sits next to the existingAscendancy: [Ascendancy]list.CharacterStartStates
_: [rid](the third[rid]) →SupportGems: [SupportGems](637 rows, 179 referenced, max index 613). Every value resolves to a support gem, e.g.TemplarActTwo→ Kulemak's Dominion, Ancestral Urgency, Long Fuse.AfflictionQuestFogBankValues columns 0, 1, 4 and 6 →
NPCs/[NPCs](979 rows). The table's single row resolves entirely to Incursion temple entries:Metadata/NPC/League/Incursion/AlvaIncursionTempleSummonKamasanGold, theAlvaIncursionTempleSummon*storage NPCs in both lists, andLeagueIncursionNew/Commander/Monsters/Boss/BlackjawPastfor column 4. Left unnamed since the role of each column is not clear from the data.Check. ggpk-explorer's lint of every declared reference against its target's row count reports no violations on 4.5.5.2 with this schema.
Not included, for the record:
CharacterStartStatescolumns 11/12 fitBaseItemTypes(max 5171 of 5496) and read as equipment for the*ActThree/*ActFivestates, but the Gamescom/demo states resolve to PoE1 leftovers, so I did not want to assert it; column 16 pairs each support gem with one of threeSkillGemsrows (CastOnElementalAilment,CastOnMeleeKill,CastOnDeath), which looks like the gem the support is socketed in but is only three distinct values.