Add the PoE2 Wordlists entries for Incursion monster names - #247
Closed
juddisjudd wants to merge 1 commit into
Closed
juddisjudd wants to merge 1 commit into
juddisjudd wants to merge 1 commit into
Conversation
Words.Wordlist reaches 60 in patch 4.5.5.2. Entries 15-60 are the Incursion architect and boss name lists, in prefix/suffix pairs, named from the Text ids of the words in each list. PoE1 stays at 14.
Contributor
Author
|
Superseded by #249, which carries both changes in a single commit on top of main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Words.Wordlistreaches 60 in PoE2 patch 4.5.5.2, while the sharedWordlistsenum stops atMERCENARY_SUFFIX(14). Entries 15 to 60 are the Incursion architect and boss name lists, in prefix/suffix pairs.This adds a PoE2 override of the enum in
poe2/_Core.gql(the same approach asStashId), so PoE1 keeps its 14 entries.How the names were derived. The
Textids of every word in a list share one stem, and each list contains either five prefixes or one suffix, for example:IncursionUniqueForgemasterPrefix1…Prefix5IncursionUniqueForgemasterSuffixIncursionRareForgehandPrefix1…Prefix5IncursionUniqueChainedBeastPrefix1…Prefix5IncursionUniqueChainedBeastSuffixEach entry is the stem in upper snake case. There are no gaps between 15 and 60, and lists 10 to 12 (
TEST,VILLAGER_*) have no words in PoE2, which matches the existing enum.Check. With this schema, ggpk-explorer's lint of every enum index in the game against its enumeration's range no longer reports
Words.Wordlist(before: values up to 60 against a 1..14 span).