Fix swapped Cold/Lightning columns in DamageCalculationTypes and name the unnamed ones - #246
Merged
Merged
Conversation
…tning stats The columns named ColdDamageStats and LightningDamageStats hold each other's stats: the Cold column resolves to *_minimum/maximum_lightning_damage and the Lightning column to the cold pair, on every row. The 28 columns after IsAttack resolve to a consistent stat across all 13 rows: the per-element stun, freeze and pin multipliers, the accuracy stats, base and double crit chance, eventual crit, and a self-reference to the row's FakeHitForAilments twin with the matching bool. Two bools stay unnamed; they are true on every real hit and false on the fake-hit and self-damage rows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ColdDamageStats and LightningDamageStats have each other's stats. On every row, the column named Cold points at *_lightning_damage and the column named Lightning at *_cold_damage. For MainHandAttack, Cold holds Stats rows 262 and 263, which are main_hand_minimum/maximum_lightning_damage. This swaps the two names. Column order and types are unchanged.
The unnamed columns after IsAttack point at the same kind of stat on all 13 rows, so this names 26 of them: the per-element stun, freeze and pin multipliers, the accuracy stats, base and double crit chance, eventual crit, and the reference to the row's *FakeHitForAilments twin with its bool.
Columns 12 and 40 stay unnamed. Both are bools that are true on real hits and false on the fake-hit and self-damage rows, and nothing in the data says which is which.
Checked at 4.5.5.1.6 by resolving every key against Stats on all 13 rows.