Skip to content

fix(alert): force closed alerts display after alert update#216

Merged
Rom1-B merged 7 commits into
pluginsGLPI:mainfrom
TarekRemo:main
Jun 9, 2026
Merged

fix(alert): force closed alerts display after alert update#216
Rom1-B merged 7 commits into
pluginsGLPI:mainfrom
TarekRemo:main

Conversation

@TarekRemo

@TarekRemo TarekRemo commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes !44398.
  • The PluginNewsAlert::post_updateItem() used to force the display of closed alerts only when is_close_allowed was set to 0. While this behavior was correct, it was not sufficient because the display must be refreshed after every update, regardless of the value of is_close_allowed.

@TarekRemo TarekRemo self-assigned this Jun 8, 2026
@TarekRemo TarekRemo requested review from Rom1-B and stonebuzz and removed request for Rom1-B and stonebuzz June 8, 2026 13:58
Comment thread tests/units/PluginNewsAlertTest.php Outdated
Comment thread tests/units/PluginNewsAlertTest.php Outdated
Comment thread tests/units/PluginNewsAlertTest.php
@TarekRemo TarekRemo requested a review from Rom1-B June 9, 2026 07:00
Comment thread tests/units/PluginNewsAlertTest.php Outdated
@TarekRemo TarekRemo requested a review from Rom1-B June 9, 2026 12:07
@Rom1-B Rom1-B merged commit 3343c10 into pluginsGLPI:main Jun 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants