-
Notifications
You must be signed in to change notification settings - Fork 0
chore(ci): scope Sonar and Codacy off the generated skill bundles #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+51
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| --- | ||
| # Codacy analyses this repository through its GitHub App; no workflow invokes | ||
| # it. Unlike SonarQube Cloud, additions here are honoured on the pull request | ||
| # that makes them — only removals wait for the default branch. | ||
| # | ||
| # Note that once this file exists, the "Ignored files" settings in the Codacy UI | ||
| # no longer apply: everything must be ignored from here. | ||
| exclude_paths: | ||
| # Generated by `bun run build:skill` from `scripts/*.ts` and committed, because | ||
| # the `npx skills` install channel copies only the skill directory and runs no | ||
| # dependency install. They are the same program as their sources, so analysing | ||
| # them reports every finding twice and counts the whole bundle as duplication. | ||
| # `eslint.config.js` and `.sonarcloud.properties` exclude the same directory. | ||
| - 'skills/*/scripts/**' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # SonarQube Cloud runs here in Automatic Analysis mode — no workflow invokes a | ||
| # scanner, the GitHub App analyses every push on its own. That mode reads this | ||
| # file and ignores `sonar-project.properties`, and it accepts no wildcards in | ||
| # these values, so paths are written as plain directory prefixes. | ||
| # | ||
| # Two consequences worth knowing before editing: | ||
| # - Only the copy on the default branch takes effect. A change here does not | ||
| # alter the analysis of the pull request that makes it; it applies once | ||
| # merged. | ||
| # - Where this file and the SonarQube Cloud UI disagree, this file wins. An | ||
| # entry that matches nothing therefore cannot be corrected from the UI while | ||
| # it is still here. | ||
|
|
||
| # Generated by `bun run build:skill` from `scripts/*.ts`, committed because the | ||
| # `npx skills` install channel copies only the skill directory and runs no | ||
| # dependency install. Analysing them scores the same program twice: every line | ||
| # of `scripts/docs.ts` reappears in the bundle, which read as 7.7% duplication | ||
| # on new code, and the `var` declarations Bun emits cost a reliability rating | ||
| # that no edit can recover — `bun run build:skill:check` byte-compares the | ||
| # bundle against a fresh build, so hand-editing it fails CI. | ||
| # `eslint.config.js` ignores the same directory, for the same reason. | ||
| sonar.exclusions=skills/spring-docs/scripts/ | ||
| sonar.cpd.exclusions=skills/spring-docs/scripts/ | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.