chore: split internal marketplace plugins out of the public settings - #16
Conversation
Adds github-actions, tidy-first, context, research and kb from the passionfactory marketplace, plus claude-code-docs from pleaseai, to the project's enabledPlugins.
There was a problem hiding this comment.
Code Review
This pull request adds several plugins to the .claude/settings.json configuration file. The feedback advises against committing internal @passionfactory marketplace plugins to the public settings file, as external contributors will not be able to resolve them. It is recommended to move these internal plugins to a local, gitignored configuration file instead.
Up to standards ✅🟢 Issues
|
|
Applies the gemini-code-assist and greptile review findings on #16. `pleaseai/spring-plugin` is a public repository, and `passionfactory` is the organization's internal marketplace. Its fourteen entries move to `.claude/settings.local.json`, which this change gitignores; the committed file keeps only what an outside contributor can actually resolve. This covers the eleven entries that were already committed, not just the ones #16 added — splitting only the new ones would leave the same problem in place with a harder-to-read history.
|



What
Two things, in order:
github-actions,tidy-first,context,research,kb, andclaude-code-docs. This is the working-tree change that accumulated during feat(docs): resolve version-matched Spring docs to a shared cache #13 and docs: document the Claude Code plugin install route #15 and was deliberately kept out of both.The split
pleaseai/spring-pluginis a public repository andpassionfactoryis the organization's internal marketplace, so its entries do not belong in a committed.claude/settings.json— an outside contributor cannot resolve any of them..claude/settings.local.json(newly gitignored) — the fourteen@passionfactoryentries.claude/settings.json— the five an outside contributor can actually resolve{ "enabledPlugins": { "claude-md-management@pleaseai": true, "vitest@pleaseai": true, "typescript-lsp@code-intelligence": true, "eslint-lsp@code-intelligence": true, "claude-code-docs@pleaseai": true } }Applied to all fourteen, not only the five this PR added: the eleven already-committed ones have the same problem, and splitting only the new ones would leave it in place behind a harder-to-read history. This matches the
pleaseai/ossconvention inSkill("standards:open-source-standards"), which/standards:setup --ossautomates.Flagged, not acted on
code-intelligenceresolves tochatbot-pf/code-intelligence— the same internal org aspassionfactory. By the rule applied above,typescript-lsp@code-intelligenceandeslint-lsp@code-intelligencebelong in the local file too. They are left committed because the agreed scope here was thepassionfactoryentries; happy to move them in this PR or a follow-up.Effect on the team
Everyone working in this repo now keeps the internal plugins in their own gitignored
.claude/settings.local.jsoninstead of getting them from the clone./standards:setup --claude-code --ossregenerates that file.