Skip to content

chore: split internal marketplace plugins out of the public settings - #16

Merged
amondnet merged 2 commits into
mainfrom
chore/enable-plugins
Sep 14, 2026
Merged

amondnet merged 2 commits into
mainfrom
chore/enable-plugins

Conversation

@amondnet

@amondnet amondnet commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

What

Two things, in order:

  1. Enables six more plugins for this project — github-actions, tidy-first, context, research, kb, and claude-code-docs. This is the working-tree change that accumulated during feat(docs): resolve version-matched Spring docs to a shared cache #13 and docs: document the Claude Code plugin install route #15 and was deliberately kept out of both.
  2. Then splits every internal-marketplace entry out of the committed settings, after review.

The split

pleaseai/spring-plugin is a public repository and passionfactory is the organization's internal marketplace, so its entries do not belong in a committed .claude/settings.json — an outside contributor cannot resolve any of them.

  • .claude/settings.local.json (newly gitignored) — the fourteen @passionfactory entries
  • .claude/settings.json — the five an outside contributor can actually resolve
{
  "enabledPlugins": {
    "claude-md-management@pleaseai": true,
    "vitest@pleaseai": true,
    "typescript-lsp@code-intelligence": true,
    "eslint-lsp@code-intelligence": true,
    "claude-code-docs@pleaseai": true
  }
}

Applied to all fourteen, not only the five this PR added: the eleven already-committed ones have the same problem, and splitting only the new ones would leave it in place behind a harder-to-read history. This matches the pleaseai/oss convention in Skill("standards:open-source-standards"), which /standards:setup --oss automates.

Flagged, not acted on

code-intelligence resolves to chatbot-pf/code-intelligence — the same internal org as passionfactory. By the rule applied above, typescript-lsp@code-intelligence and eslint-lsp@code-intelligence belong in the local file too. They are left committed because the agreed scope here was the passionfactory entries; happy to move them in this PR or a follow-up.

Effect on the team

Everyone working in this repo now keeps the internal plugins in their own gitignored .claude/settings.local.json instead of getting them from the clone. /standards:setup --claude-code --oss regenerates that file.

Adds github-actions, tidy-first, context, research and kb from the
passionfactory marketplace, plus claude-code-docs from pleaseai, to the
project's enabledPlugins.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds several plugins to the .claude/settings.json configuration file. The feedback advises against committing internal @passionfactory marketplace plugins to the public settings file, as external contributors will not be able to resolve them. It is recommended to move these internal plugins to a local, gitignored configuration file instead.

Comment thread .claude/settings.json Outdated
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 14, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 4/5

The change is generally low risk, but the internal marketplace entries should be moved to local settings before merging to avoid expanding unusable public configuration.

Fix All in Claude CodeFindings

  1. P2 Internal plugins in public settings
Fix with agent prompt
### Issue 1
.claude/settings.json:16-19
This public configuration adds five more plugins from the internal `passionfactory` marketplace, including `kb@passionfactory` on line 21. External contributors cannot resolve these entries, so expanding the committed list exposes them to more unavailable plugins. Keep internal-only entries in the gitignored `.claude/settings.local.json` instead.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

  • Adds five plugins from the internal passionfactory marketplace.
  • Adds claude-code-docs from the pleaseai marketplace.
  • The internal entries should remain local in a public repository so external contributors are not presented with unresolvable plugins.

Reviews (1) · Last reviewed commit: "chore: enable six more plugins for this ..."

Comment thread .claude/settings.json Outdated
Applies the gemini-code-assist and greptile review findings on #16.

`pleaseai/spring-plugin` is a public repository, and `passionfactory` is the
organization's internal marketplace. Its fourteen entries move to
`.claude/settings.local.json`, which this change gitignores; the committed file
keeps only what an outside contributor can actually resolve.

This covers the eleven entries that were already committed, not just the ones
#16 added — splitting only the new ones would leave the same problem in place
with a harder-to-read history.
@sonarqubecloud

Copy link
Copy Markdown

@amondnet amondnet changed the title chore: enable six more plugins for this project chore: split internal marketplace plugins out of the public settings Sep 14, 2026
@amondnet
amondnet merged commit cfd38be into main Sep 14, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant