Skip to content

Add platform properties functionality to mettle workers - #352

Open
scyyx5 wants to merge 2 commits into
please-build:masterfrom
scyyx5:enable-platform-properties
Open

scyyx5 wants to merge 2 commits into
please-build:masterfrom
scyyx5:enable-platform-properties

Conversation

@scyyx5

@scyyx5 scyyx5 commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@Hamishpk Hamishpk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small nits but otherwise looks good to me

Comment thread mettle/worker/worker.go
Comment thread mettle/worker/worker_platform_test.go
@peterebden

Copy link
Copy Markdown
Member

I know this was a little while ago, sorry, but what's this for? It doesn't seem to do much - in my head the API servers need to know about platform props but I'm not sure what the workers would do with them.

@Hamishpk

Copy link
Copy Markdown
Contributor

I know this was a little while ago, sorry, but what's this for? It doesn't seem to do much - in my head the API servers need to know about platform props but I'm not sure what the workers would do with them.

This was back when we were toying with the idea of not using a tmp directory for larger actions so workers weren't using crazy amounts of RAM. We aren't going in that direction any more so maybe not relevant anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants