Add plugin config to require licence - #56
Open
jwong-beep wants to merge 5 commits into
Open
Conversation
jwong-beep
requested review from
chrisnovakovic and
peterebden
and removed request for
peterebden
August 12, 2026 14:30
peterebden
reviewed
Aug 12, 2026
peterebden
left a comment
peterebden
left a comment
Contributor
There was a problem hiding this comment.
This seems fine to me as a feature, but I don't think it should warn on the other path.
FWIW I kind of think log.warning is a bit of a mistake in BUILD files - you generally don't want it appearing in every build so you end up wanting things to work silently or enforce a failure.
Co-authored-by: Chris Novakovic <chris@chrisn.me.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
require_licenceconfig option to the plugin