Player.OnQuit callback issue

[sarvagya6298]

What happened?

If i have multiple players joined in together in a game.
So, when a player leaves onQuit it should remove the player and if i check the count of the players now via Playroomkit.GetPlayers() i should be getting the correct one.

Example, 4 players were in game. So if 1 leaves the count should become 3. But if 2 players leave together within a difference of fractions of ms then the callback works for 1 player only. The current count should now be 1 but it remains 2 because it missed the second callback who left.

Version

0.0.29

What is your environment?

Unity version 2022.3.43f1, windows, chrome

Link to original discussion

https://discord.com/channels/997752993598419044/1128151935669764096/1284579964057813022

Relevant log output

No response

[maclo4]

@SaadBazaz Do you have any updates on this bug? Quitting and rejoining a room currently doesnt seem to work

[tulayha]

@SaadBazaz @momintlh Issue with Playroomkit.GetPlayers() due to players not being removed from internal dictionary on quit.
GetPlayers() is supposed to be an internal static getter.

But if 2 players leave together within a difference of fractions of ms then the callback works for 1 player only. The current count should now be 1 but it remains 2 because it missed the second callback who left.

This still needs to be looked into.

[tulayha]

@SaadBazaz Player count issue has been resolved: #157
Getter is still left as public atm as that is public API at this point.

Example, 4 players were in game. So if 1 leaves the count should become 3. But if 2 players leave together within a difference of fractions of ms then the callback works for 1 player only. The current count should now be 1 but it remains 2 because it missed the second callback who left.

Additional details required for the potentially second issue in the provided example if this still persists. That can be added as a new issue when the following is confirmed:

• Are both callbacks being triggered on game-side code with only issue being the count returned by Playroomkit.GetPlayers()? Or only 1 callback is being received when triggered?