Repository navigation
Fix SA/VU power double multiply on the non-DVFS branch - #8
Merged
XZman merged 1 commit intoSep 5, 2026
Merged
Conversation
The `ChipConfig` properties `static_power_sa_W` and `dynamic_power_sa_W` already return chip totals (`*_per_sa * num_sa`), and the VU pair likewise. The scaling by `num_sa` / `num_vu` sat on a path shared by both branches of `if config.enable_dvfs`, so the non-DVFS branch applied it twice.
XZman
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ChipConfigpropertiesstatic_power_sa_Wanddynamic_power_sa_Walready return chip totals (*_per_sa * num_sa), and the VU pair likewise. The scaling bynum_sa/num_vusat on a path shared by both branches ofif config.enable_dvfs, so the non-DVFS branch applied it twice.enable_dvfsdefaults toFalse(ChipConfig.py:93) andrun_power_gating.shpasses no--dvfs, soenergy_operator_analysis_main.py:85-86leaves it false. The default DVFS disabled path is theaffected one; the DVFS path was already correct.