Repository navigation
Report the target server state after a lost target connection - #71
Open
teknogeek0 wants to merge 1 commit into
Open
teknogeek0 wants to merge 1 commit into
teknogeek0 wants to merge 1 commit into
Conversation
At the start of the copy, log the target server start time and the CREATE INDEX memory budget (index jobs times maintenance_work_mem). When a COPY, CREATE INDEX, or VACUUM worker loses its target connection, connect again and log whether the target restarted, terminated the session, or cannot be reached.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the start of the copy, pgcopydb logs the target
pg_postmaster_start_time()and the CREATE INDEX memory budget (--index-jobstimesmaintenance_work_mem, withmax_parallel_maintenance_workers). When a COPY, CREATE INDEX, or VACUUM worker loses its target connection,copydb_target_report()connects again and logs the SQLSTATE and one of these results: the target restarted, the target did not restart (a process terminated the session), or the target cannot be reached. The logic is intarget_state.c.The new
index-target-terminatesuite slows one CREATE INDEX with a target event trigger and ends it withpg_terminate_backend(). The log shows SQLSTATE57P01and "Target server did not restart".Tests: full PG18 suite, 36 of 36 suites pass.