Repository navigation
Allow VACUUM to run again for a table on --resume - #70
Open
teknogeek0 wants to merge 1 commit into
Open
teknogeek0 wants to merge 1 commit into
teknogeek0 wants to merge 1 commit into
Conversation
A resume after a failed index phase sends tables that the earlier run already vacuumed to VACUUM again. The plain insert into vacuum_summary broke its unique(tableoid) constraint and failed the resume. Use insert or replace, and add the resume-vacuum test suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A resume after a failed index phase sends tables that the earlier run already vacuumed to VACUUM again. The plain insert into
vacuum_summarybroke itsunique(tableoid)constraint ([SQLite 19] constraint failed) and failed the resume. This change usesinsert or replace.The new
resume-vacuumsuite makes one CREATE INDEX fail on the first clone, then runsclone --resume. It fails without the fix and passes with it.Tests: full PG18 suite, 36 of 36 suites pass.