Repository navigation
Default PGVERSION to 18 - #65
Merged
Merged
Conversation
The build image, the Makefile and every test suite defaulted to PostgreSQL 16 or 17. They now default to 18. Twelve compose files built their source database from Dockerfile.pg but passed no build args, so the ARG default was the only value that applied and the source ignored the matrix. They now pass PGVERSION. The follow-wal2json and follow-target-reconnect source images carried a fixed tag, which let one version reuse another version's image; the tag now follows PGVERSION. The exclude-extension test hardcoded pgcopydb:pg16 and so failed on PG17 and PG18. All 37 suites pass at PGVERSION=18. citus_indent --check passes. The timescaledb suite is excluded; it is broken and disabled in CI.
DmitriiAn
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build image, the Makefile and every test suite defaulted to PostgreSQL 16 or 17. They now default to 18.
Twelve compose files built their source database from
Dockerfile.pgbut passed no build args, so theARGdefault was the only value that applied and the source ignored the matrix. They now passPGVERSION. Thefollow-wal2jsonandfollow-target-reconnectsource images carried a fixed tag, which let one version reuse another version's image; the tag now followsPGVERSION. Theexclude-extensiontest hardcodedpgcopydb:pg16and so failed on PG17 and PG18.The published image now carries the PostgreSQL 18
pg_dumpandpg_restore.Tests
All 37 suites pass at
PGVERSION=18.make buildpasses.citus_indent --checkpasses. All 38 compose files parse.timescaledbis excluded. It is broken and commented out of the CI matrix; the same failure reproduces on an unchanged tree at PG16.exclude-extensionnow passes. It was recorded as a pre-existing failure in #59 because of the hardcoded image. It is still absent from the CI matrix.Tested at PG18 only. The twelve newly wired suites will run a PG16 and PG17 source in CI for the first time.