feat(solver): allow plugging external reasoners - #243
Open
nrealus wants to merge 2 commits into
Open
Conversation
extra reasoners are stored in a vector of options, at indices equal to their ids
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the reasoners API to allow plugging in custom external reasoners on demand.
The verbosity of this new API is comes from the need to please the borrow checker in the loop over theories in
solver_impl.rs.Indeed, if I recall correctly (these commits are actually quite old), there were no issues with it before because
Theoryhad astaticlifetime.