Skip to content

[PIXELS-1374] Propagate SQL NULL via Retina isNull instead of empty bytes #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bianhq merged 1 commit into from
Aug 15, 2026
Merged

[PIXELS-1374] Propagate SQL NULL via Retina isNull instead of empty bytes #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions ...n/java/io/pixelsdb/pixels/sink/conversion/debezium/support/DebeziumRowValueConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,9 @@ private SinkProto.ColumnValue.Builder parseConnectValue(
}
if (raw == null)
{
return SinkProto.ColumnValue.newBuilder().setValue(ByteString.EMPTY);
return SinkProto.ColumnValue.newBuilder()
.setValue(ByteString.EMPTY)
.setIsNull(true);
}

if (schemaName != null)
Expand Down Expand Up @@ -631,8 +633,8 @@ private SinkProto.ColumnValue.Builder parseValue(JsonNode valueNode, String fiel
if (valueNode == null || valueNode.isNull())
{
return SinkProto.ColumnValue.newBuilder()
// .setName(fieldName)
.setValue(ByteString.EMPTY);
.setValue(ByteString.EMPTY)
.setIsNull(true);
}

SinkProto.ColumnValue.Builder columnValueBuilder = SinkProto.ColumnValue.newBuilder();
Expand Down Expand Up @@ -743,7 +745,8 @@ private SinkProto.ColumnValue.Builder parseCanonicalValue(
if (raw == null)
{
return SinkProto.ColumnValue.newBuilder()
.setValue(ByteString.EMPTY);
.setValue(ByteString.EMPTY)
.setIsNull(true);
}
if (raw instanceof JsonNode jsonNode)
{
Expand Down
14 changes: 14 additions & 0 deletions src/main/java/io/pixelsdb/pixels/sink/event/RowChangeEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,20 @@ public List<ByteString> getAfterData()
return colValueList;
}

/**
* Parallel to {@link #getAfterData()}: {@code true} means SQL NULL at that column.
*/
public List<Boolean> getAfterIsNull()
{
List<SinkProto.ColumnValue> colValues = rowRecord.getAfter().getValuesList();
List<Boolean> isNullList = new ArrayList<>(colValues.size());
for (SinkProto.ColumnValue col : colValues)
{
isNullList.add(col.getIsNull());
}
return isNullList;
}

@Override
public String toString()
{
Expand Down
6 changes: 4 additions & 2 deletions src/main/java/io/pixelsdb/pixels/sink/writer/retina/RetinaPayloadBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,16 @@ private static void addRowChange(
{
RetinaProto.InsertData.Builder insertData = RetinaProto.InsertData.newBuilder()
.addIndexKeys(event.getAfterKey())
.addAllColValues(event.getAfterData());
.addAllColValues(event.getAfterData())
.addAllIsNull(event.getAfterIsNull());
builder.addInsertData(insertData);
}
case UPDATE ->
{
RetinaProto.UpdateData.Builder updateData = RetinaProto.UpdateData.newBuilder()
.addIndexKeys(event.getAfterKey())
.addAllColValues(event.getAfterData());
.addAllColValues(event.getAfterData())
.addAllIsNull(event.getAfterIsNull());
builder.addUpdateData(updateData);
}
case DELETE ->
Expand Down
4 changes: 4 additions & 0 deletions ...va/io/pixelsdb/pixels/sink/conversion/debezium/support/DebeziumRowValueConverterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@

import static org.junit.jupiter.api.Assertions.assertArrayEquals;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertFalse;
import static org.junit.jupiter.api.Assertions.assertThrows;
import static org.junit.jupiter.api.Assertions.assertTrue;

Expand Down Expand Up @@ -69,7 +70,9 @@ void shouldEncodeCanonicalStructJsonAndAvroValues() throws Exception
assertEquals("TDSQL value ", value.getValues(1).getValue().toStringUtf8());
assertArrayEquals(longBytes(2471035L), bytes(value, 2));
assertEquals(0, value.getValues(3).getValue().size());
assertTrue(value.getValues(3).getIsNull());
assertEquals("", value.getValues(4).getValue().toStringUtf8());
assertFalse(value.getValues(4).getIsNull());

ObjectNode jsonRow = new ObjectMapper().createObjectNode();
jsonRow.put("id", 9223372036854775806L);
Expand Down Expand Up @@ -195,6 +198,7 @@ void shouldEncodeConnectPrimitiveValuesAsExactBytes() throws Exception
assertArrayEquals(
new byte[]{0x10, 0x20, (byte) 0xfe, 0x00}, bytes(value, 11));
assertArrayEquals(new byte[0], bytes(value, 12));
assertTrue(value.getValues(12).getIsNull());
}

@Test
Expand Down
38 changes: 38 additions & 0 deletions src/test/java/io/pixelsdb/pixels/sink/writer/retina/RetinaPayloadBuilderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,15 @@ void shouldBuildCompleteUpdateRecordRequest() throws Exception
assertEquals(2, tableUpdate.getInsertDataCount());
assertRow(tableUpdate.getInsertData(0).getIndexKeys(0),
tableUpdate.getInsertData(0).getColValuesList(), "1", "insert");
assertEquals(List.of(false, false), tableUpdate.getInsertData(0).getIsNullList());
assertRow(tableUpdate.getInsertData(1).getIndexKeys(0),
tableUpdate.getInsertData(1).getColValuesList(), "2", "snapshot");
assertEquals(List.of(false, false), tableUpdate.getInsertData(1).getIsNullList());

assertEquals(1, tableUpdate.getUpdateDataCount());
assertRow(tableUpdate.getUpdateData(0).getIndexKeys(0),
tableUpdate.getUpdateData(0).getColValuesList(), "3", "after");
assertEquals(List.of(false, false), tableUpdate.getUpdateData(0).getIsNullList());

assertEquals(1, tableUpdate.getDeleteDataCount());
assertEquals(bytes("4"), tableUpdate.getDeleteData(0).getIndexKeys(0).getKey());
Expand All @@ -85,6 +88,41 @@ void shouldBuildCompleteUpdateRecordRequest() throws Exception
assertEquals(request, RetinaProto.UpdateRecordRequest.parseFrom(request.toByteArray()));
}

@Test
void shouldPropagateIsNullAlongsideColValues() throws Exception
{
TableMetadata metadata = tableMetadata();
RowChangeEvent withNull = event(
SinkProto.OperationType.INSERT,
null,
SinkProto.RowValue.newBuilder()
.addValues(SinkProto.ColumnValue.newBuilder().setValue(bytes("5")))
.addValues(SinkProto.ColumnValue.newBuilder()
.setValue(ByteString.EMPTY)
.setIsNull(true))
.build(),
metadata);
RowChangeEvent emptyString = event(
SinkProto.OperationType.UPDATE,
row("6", "before"),
SinkProto.RowValue.newBuilder()
.addValues(SinkProto.ColumnValue.newBuilder().setValue(bytes("6")))
.addValues(SinkProto.ColumnValue.newBuilder().setValue(ByteString.EMPTY))
.build(),
metadata);

RetinaProto.TableUpdateData tableUpdate =
RetinaPayloadBuilder.buildTableUpdateData(
TABLE_NAME, TIMESTAMP, List.of(withNull, emptyString));

assertEquals(List.of(false, true), tableUpdate.getInsertData(0).getIsNullList());
assertEquals(bytes("5"), tableUpdate.getInsertData(0).getColValues(0));
assertEquals(ByteString.EMPTY, tableUpdate.getInsertData(0).getColValues(1));

assertEquals(List.of(false, false), tableUpdate.getUpdateData(0).getIsNullList());
assertEquals(ByteString.EMPTY, tableUpdate.getUpdateData(0).getColValues(1));
}

private static void assertRow(
io.pixelsdb.pixels.index.IndexProto.IndexKey indexKey,
List<ByteString> columnValues,
Expand Down
Loading