security: intraday HTF bucket finalizes when the input bar reaches the bucket end (thin sessions) - #165
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An intraday
request.securitybucket built from finer input bars (feed_ratio_mode) is finalized when the input bar's end reaches the bucket's real end — not only when the sub-bar count reaches the ratio or when the next bucket's first bar crosses the boundary (lab finding 467/472). On a thin session (a 60-minute bucket with 56 present minutes, e.g. the first hour after the forex open, or Christmas Eve) the old rule completed the bucket on the boundary bar inside the next chart bar, sosecurity(...)[1]flipped one chart bar later than on TradingView. The round-7 session-close clip is kept (an RTH '240' bucket never reaches its real end inside the session); all completion paths are guarded so a bucket is never emitted twice, which makes the change a no-op on gap-free feeds.Evidence: OANDA:EURUSD oscar-lab-mtf-smc-signal-v2 233/238 → 236/238 (excellent), masayanfx 313 → 318/324; every other measured tape byte-identical (EURUSD/AAPL probes, raphaeltay, ETH 5/5). ETH population 396/396, corpus 309/2/1 (promote).
tests/test_htf_bucket_real_end.cpp(568 checks, incl. last-minute-missing and DST cases); ctest 142/142.