session symbols round 7: HTF completion/warm-up on the symbol clock, prearmed brackets at the fill open, syminfo.type, 24h session strings, trail_offset ticks, Qty export - #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round 7 of the session-symbol parity campaign (NASDAQ:AAPL / OANDA:EURUSD lanes; BINANCE:ETHUSDT.P 24×7 stays bit-identical apart from three TV-faithful moves noted below). Seven generic fixes, each measured in isolation and as a composition (lab findings 458–465):
src/timeframe.cpp, finding 458): the last intradayrequest.securitybucket of an RTH day ('240'/'60'/'45') completes at the session close; equity W/M complete on the period's last traded session bar (Fri + 24 h is Saturday, not next week); forex W/M complete on Friday 16:45 ET of the wrapped 1700–1700 session. raphaeltay-dual-cof-4h-45m (AAPL) 22.4 % → 100 %; the weekly EURUSD probe → 100 %.request.securitywarm-up sees only HTF buckets whose open is inside the loaded range (finding 465): a straddling first bucket is absent, not a partial bar 1. heneralmomo25 (EURUSD) weak → excellent; mayur-das4 weak → strong; masayanfx → excellent.syminfo.typeis settable (strategy_set_syminfo_type/set_syminfo_string, runtime_overrides.type; finding 462): forex pip auto-detection no longer runs on the "crypto" default.time/time_close/session filters on '1700-1700' returned na, so everyminute(time_close)gate on the forex lane was dead. vasudevshenoy 152 → 439/451.trail_offsettruncates to whole ticks (finding 463): TV uses floor (58/62 EURUSD, 11/11 on the ETH nils orb strategy);trail_pointskeeps its evidence-backed ceil.engine_trades.csvprints Qty at lot precision (finding 460): the%gexport truncated to 6 significant digits (92293.36 → 92293.4, ≥1e6 → 1e+06).ETH population: 396/396 unchanged, corpus 309/2/1 (promote). Three ETH tapes change bytes without any tier move: bprakaash (368 → 371/371 — TV's own duration-0 rows), nils123456-orb-strat (11 trail exits move to TV's tick), alpha-wizard-wave (Qty column text). ctest 141/141.