Skip to content

chore: drop EOL Node 20.x from CI matrix #41

Description

@pinecone-groundskeeper

Problem

.github/workflows/ci.yml's build-and-test job ran its matrix against node-version: [20.x, 22.x]. Node.js 20 ("Iron") reached end-of-life on 2026-03-24 and no longer receives security or bug fixes, so CI was validating the project against an unsupported runtime.

Solution

Swap the matrix to the two currently-supported LTS lines: [22.x, 24.x]. Left the audit job's pinned node-version: 22.x as-is, per the issue's "reviewer's call" note — no other workflow behavior changes.

Verification

Installed dependencies and ran the full CI check sequence locally on Node 24.18.0 (matching the new upper bound):

  • npm run lint — passes
  • npm run format:check — passes
  • npm run typecheck — passes
  • npm test — 23/23 tests passed across 5 files

(Dependency install required --ignore-scripts in this sandbox because onnxruntime-node's postinstall tries to fetch a native binary from api.nuget.org, which isn't reachable in this restricted network — unrelated to this change and not exercised by lint/typecheck/test.)

Follow-ups

None — this is scoped to the Node version matrix only, per the issue.

Closes #32

Generated by GitHub Maintenance Fixer · sonnet50 · 55.8 AIC · ⌖ 16.5 AIC · ⊞ 8.1K · ◷


Note

This was originally intended as a pull request, but the git push operation failed.

Original error: The process '/usr/bin/git' failed with exit code 128

Workflow Run: View run details and download bundle artifact

The bundle file is available in the agent artifact in the workflow run linked above.

To create a pull request with the changes:

# Download the artifact from the workflow run
gh run download 30653989934 -n agent -D /tmp/agent-30653989934

# Fetch the bundle into a temporary ref, then update the local branch
git fetch /tmp/agent-30653989934/aw-pinecone-io-recommender-example-typescript-agent-maintenance-issue-32.bundle refs/heads/agent/maintenance/issue-32:refs/bundles/create-pr-agent-maintenance-issue-32-5c6484d345c1ea78-d4d859bf
git update-ref refs/heads/agent/maintenance/issue-32-5c6484d345c1ea78 refs/bundles/create-pr-agent-maintenance-issue-32-5c6484d345c1ea78-d4d859bf
git checkout agent/maintenance/issue-32-5c6484d345c1ea78
# Ensure the working tree matches the updated branch
git reset --hard
# Remove the temporary bundle ref
git update-ref -d refs/bundles/create-pr-agent-maintenance-issue-32-5c6484d345c1ea78-d4d859bf

# Push the branch to origin
git push origin agent/maintenance/issue-32-5c6484d345c1ea78

# Create the pull request
gh pr create --title 'chore: drop EOL Node 20.x from CI matrix' --base main --head agent/maintenance/issue-32-5c6484d345c1ea78 --repo pinecone-io/recommender-example-typescript

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent:maintenanceOpened/maintained by the maintenance agent; it recognizes its own work by this labelagentic-workflows

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions