Repository navigation
Conversation
Move signing into the built-ins crate while preserving endpoint configuration and existing Rust signing exports. Verify the final payload hash after body transformations and keep AWS credentials outside external middleware preflights. Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validate the HTTP session API proposed in NVIDIA/OpenShell#4359 with AWS SigV4 signing. External request middleware can transform the body first; the supervisor then signs the final request with credentials that never enter the external middleware protocol.
This draft lives in the personal fork as a validation example. Its base is frozen at upstream PR head
0dc751b086dd3a2190b9b87fba956e2ea36fd6c7, so the diff contains only this use case.Related Issue
Validation for NVIDIA/OpenShell#4359, part of NVIDIA/OpenShell#2431. This fork has issues disabled; this validation draft does not close an upstream issue.
Changes
Testing
mise run pre-commitpasses.Shared runtime validation: the Docker HTTP session content-guard E2E suite passed with both signing implementations applied. No live AWS requests were tested. The full repository suite stopped at
endpoint_selector_single_star_crosses_path_separators; the same prover failure reproduces on the unchanged upstream PR head.Checklist
The trusted signer is selected by endpoint signing fields. It is not an externally registered service or a
network_middlewaresbinding. This validates composition with the session API without adding a public credential-visible hook.Companion validation: Git signing, based independently on the same frozen API head.