feat(motd): source banners from pilot-changelog feed-motd.json#285
Open
Alexgodoroja wants to merge 1 commit into
Open
feat(motd): source banners from pilot-changelog feed-motd.json#285Alexgodoroja wants to merge 1 commit into
Alexgodoroja wants to merge 1 commit into
Conversation
Move the message-of-the-day source off the bespoke pilot-motd repo and onto pilot-changelog's existing render pipeline. The daemon now polls feed-motd.json — the `scope: motd` per-scope output of the changelog — where each entry's `date` is the active UTC day and `title` is the banner text. - internal/motd: parse the pilot-changelog feed shape (entries[].title -> banner text); default feed URL -> pilot-changelog feed-motd.json. Selection, mirroring, UTC re-validation, and the CLI banner / important_update / info surfaces are all unchanged. - tests: parse the real feed-motd.json entry shape (extra fields ignored); updated fixtures to the new shape. - docs/motd.md, CHANGELOG [Unreleased]: note the source move. No user-visible behavior change; only the source feed and its shape move. Pairs with TeoSlayer/pilot-changelog (adds the motd scope).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the message-of-the-day source off the bespoke
pilot-motdrepo and ontopilot-changelog's existing render pipeline — so MOTD rides the rails that were already there instead of duplicating them.Pairs with pilot-protocol/pilot-changelog#1 (adds the
motdscope +feed-motd.json).What changes
internal/motdparses the pilot-changelog feed shape:entries[].title→ banner text,entries[].date→ active UTC day (extra fields ignored).DefaultFeedURL→…/TeoSlayer/pilot-changelog/main/feed-motd.json.SelectForToday), the local mirror (~/.pilot/motd.json), UTC-day re-validation on read, the text banner, theimportant_updateenvelope field, andmotdininfoare all unchanged.feed-motd.jsonentry shape.docs/motd.md+CHANGELOG [Unreleased] → Changednote the source move.No behavior change
Users see the same banner /
important_update/infosurfaces. Only the source feed and its JSON shape move.--motd-feed-url/$PILOT_MOTD_URLoverrides still work; empty still disables.Test
go build ./...,go vet,go test ./internal/motd/ ./cmd/pilotctl/— all pass.pilot-daemonfrom this branch, served the actual renderedfeed-motd.json(ascope: motdentry) locally, and confirmed the daemon mirrored it andpilotctlrenderedMessage of the day: …, withimportant_updatein--jsonandmotdininfo.Rollout
Ships in the next daemon release;
pilot-changelog#1must merge first sofeed-motd.jsonexists onmain.pilot-motdis then retired (separate deprecation PR).