fix(security): add decompression bomb protection to untarUnder (PILOT-418)#284
Closed
matthew-pilot wants to merge 2 commits into
Closed
fix(security): add decompression bomb protection to untarUnder (PILOT-418)#284matthew-pilot wants to merge 2 commits into
matthew-pilot wants to merge 2 commits into
Conversation
…-418) The untarUnder function used io.Copy without a per-file size limit when extracting tar.gz entries from app store catalogue bundles. While the HTTP download is capped at 1 MiB, a maliciously crafted archive with an extreme compression ratio could fill disk. Fix: wrap tar entry extraction with io.LimitReader(tr, 64<<20) for a 64 MiB per-file maximum. Closes PILOT-418
matthew-pilot
added
canary-failed
Collaborator
Author
|
Superseded by #288 — closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
untarUnderfunction incmd/pilotctl/appstore_catalogue.goextracts tar entries from app store catalogue bundles without a per-file size limit.Why
While the HTTP download is already capped at 1 MiB (
io.LimitReader(body, 1<<20)), a maliciously crafted tar.gz with an extreme compression ratio could bypass this cap and fill disk through decompression.Fix
Wrap the tar entry extraction with
io.LimitReader(tr, 64<<20)— a 64 MiB per-file maximum. This matches the size limit used by similar extraction functions in the codebase.Verification
go build ./cmd/pilotctl/— passesgo vet ./cmd/pilotctl/...— cleancmd/pilotctl/appstore_catalogue.go(+5/-2 lines)Closes PILOT-418