fix: inject nodeID into telemetry events and add catalogue_viewed payload#281
Merged
Merged
Conversation
…load
- pkg/telemetry/client.go: Send() now injects c.nodeID into events
that don't supply their own NodeID, so telemetry events carry the
correct node identity instead of always being 0
- cmd/pilotctl/appstore_catalogue.go: catalogue_viewed event now sends
payload {"surface":"catalogue"} instead of empty {}
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Client.Send()now injectsc.nodeIDinto outgoing events where the caller leftNodeID == 0. Previously thenodeIDfield stored at construction time was never written into the event struct before marshaling.appstore_catalogue.gonow sends{"surface":"catalogue"}in the event payload so the server has context for the event.Test plan
go build ./...— no compilation errors (pre-commit hook passed)go vet ./...— no issues (pre-commit hook passed)🤖 Generated with Claude Code