feat(telemetry): emit install events (PILOT-401)#273
Closed
matthew-pilot wants to merge 1 commit into
Closed
Conversation
Adds a consent-gated telemetry client package and hooks it into the appstore install command. On every successful app install, a signed telemetry event carrying app_id, version, and source (catalogue|local) is POSTed to the configured telemetry endpoint. Telemetry is gated by the PILOT_TELEMETRY_URL env var — when empty (default), the client is a hard no-op: no dial, no goroutines, no allocations. When set, the client signs events with the node Ed25519 identity and sends them via a signed HTTP POST. Acceptance: - Exactly one event per successful install (no double-count on --force) - No event on failure (install aborted before the telemetry hook) - Consent gate: no-op when PILOT_TELEMETRY_URL is empty Closes PILOT-401
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| ts := strconv.FormatInt(time.Now().Unix(), 10) | ||
| // Build signed message as ts + newline + body. | ||
| message := make([]byte, 0, len(ts)+1+len(body)) |
4 tasks
Collaborator
|
Superseded by #277 which combines PILOT-401/402/406/407 into a clean branch off current main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Emit a telemetry event on successful app install, gated by consent (no-op when
PILOT_TELEMETRY_URLis empty oridentity.jsonis absent).Changes
pkg/telemetry/client.go— New package: consent-gated telemetry client with Ed25519-signed HTTP POSTs. Hard no-op when URL is empty. IncludesNewClientFromIdentity(url, identityPath, nodeID)convenience constructor.pkg/telemetry/client_test.go— Tests: disabled no-op, identity loading, signer configuration, HTTP round-trip, error propagation.cmd/pilotctl/appstore.go— After a successful install (bundle validated, manifest planted, audit logs written), emit anapp_installedevent withapp_id,version, andsource(catalogue|local).Acceptance criteria
--force)PILOT_TELEMETRY_URLis emptyVerification
go build ./...— cleango vet ./...— cleango test ./pkg/telemetry/— 10/10 PASSCloses PILOT-401