Repository navigation
Conversation
|
@cnlohr is it possible to get this merged in so I can get my CircuitPython PR closed? Anything else you need from me to close this? |
|
At this point, I don't know if I can review pidcodes, it went from a project every few days to now, claude or codex is applying for a new pidcode on someone's behalf every hour or two. That said - to get a PID code, you need to also publish your firmware. Your hardware documentation meets all the requirements. |
|
Is the link to CircuitPython not enough? That's the primary reason for getting a PID here is because CircuitPython requires one for every board supported. Sorry to see all these PRs piling up due to AI projects. I noticed the number seems to grow daily. I generally don't submit a lot, I did before for boards I developed under my old company Oak Development Technologies. |
|
I don't actually know the situation with circuitpython for this, but it is confusing to me that it would expect a unique PID per board. Any chance @tannewt can explain the situation there? Is just hardware + the stub sufficient for a pidcode? |
This has been the case in the past. Board support in CircuitPython has done a few things: |
|
Generally we think it's best for a unique USB PID per hardware + software combination. So we generally do 3 PIDs per board, one for the bootloader, one for Arduino and one for CircuitPython. We don't do a PID per possible USB descriptor because that gets large quickly. For CircuitPython and QMK I want to see the board definition somewhere to warrant a new PID.
I'll try to do a pass soon too. I'm going to experiment with an LLM to dig for the actual files too. That's where most of the work is. We could also change the PR template to make it very explicit. |
Adding new organization for Kavrous technologies and adding new PixelWing ESP32-S3