Repository navigation
feat(constraints): add prefix_tablename option to Unique and Check constraints (#1437) - #1441
Open
shadialhasan wants to merge 1 commit into
Open
shadialhasan wants to merge 1 commit into
shadialhasan wants to merge 1 commit into
Conversation
…nstraints (piccolo-orm#1437) - Support prefix_tablename=True in Unique and Check constraints - Ensure Constraint instances and columns are safely copied in TableMetaclass for mixin inheritance - Automatically prefix index and constraint names with table name to prevent PostgreSQL collisions across mixin consumers - Add full test coverage in test_constraints.py and test_schema_differ.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1437
When multiple Table classes inherit a Unique constraint from a common mixin, PostgreSQL requires index names across tables in the same schema to be unique; attempting to apply identical index names results in
elation already exists.
This PR implements the solution suggested in #1437:
Checks