Skip to content

Add support for Siemens physlogs#494

Open
slugtmeijer wants to merge 14 commits into
physiopy:masterfrom
slugtmeijer:add/siemens-physlog-reader
Open

Add support for Siemens physlogs#494
slugtmeijer wants to merge 14 commits into
physiopy:masterfrom
slugtmeijer:add/siemens-physlog-reader

Conversation

@slugtmeijer

Copy link
Copy Markdown

Function added to include physiological measures from a Siemens scanner. This takes into account different sampling rates for the different measures and that physiological might have been started manually so have different start/end times. By default is uses the dicom file to get the start trigger time of the aquisition.

Closes #

Proposed Changes

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

Function added to include physiological measures from a Siemens scanner. This takes into account different sampling rates for the different measures and that physiological might have been started manually so have different start/end times. By default is uses the dicom file to get the start trigger time of the aquisition.

Co-Authored-By: Stefano Moia <s.moia.research@gmail.com>
Co-Authored-By: Brandon Ingram <brandoningram25@yahoo.co.uk>
@github-actions github-actions Bot added the Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog label Jun 11, 2026
slugtmeijer and others added 5 commits June 11, 2026 17:53
Co-Authored-By: Selma Lugtmeijer <134110542+slugtmeijer@users.noreply.github.com>
Co-Authored-By: Carsten Schmidt-Samoa <51449795+CarstenSchmidt-Samoa@users.noreply.github.com>
Co-Authored-By: Selma Lugtmeijer <134110542+slugtmeijer@users.noreply.github.com>
Co-Authored-By: Carsten Schmidt-Samoa <51449795+CarstenSchmidt-Samoa@users.noreply.github.com>
Feat/siemensMerge pull request #2 from smoia/feat/siemens
@github-actions github-actions Bot added the Testing This is for testing features, writing tests or producing testing code label Jun 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog Testing This is for testing features, writing tests or producing testing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants