Repository navigation
Expect float ranges from Assert::integerish() with PHPStan 2.3.6 - #236
Merged
Merged
Conversation
Floats loosely equal to an int cast are now narrowed to the int range, which leaves out INF, -INF and NAN. Amp-Thread-ID: https://ampcode.com/threads/T-01a1ad71-9d5a-7120-9844-bfb0954d122f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With PHPStan 2.3.6 (phpstan/phpstan-src#6937),
Assert::integerish()narrows floats tofloat<-9.223372036854776E+18, 9.223372036854776E+18>. That dropsINF,-INFandNAN, which really fail$value != (int) $value, so the new types are correct and more precise.Bumps
phpstan/phpstanto^2.3.6and updates the expectations intype.php.The remaining failure in
comparison.php:82(non-empty-string|numeric-stringinstead ofnon-empty-string) is a union normalization gap in phpstan-src and will be fixed there.