Repository navigation
Claude react on review: Fix the hardened check - #6965
Merged
Merged
Conversation
…view.author_association which does not work for regular maintainers.
Contributor
Author
|
we need to apply this fix also on phpstan/phpstan |
VincentLanglet
approved these changes
Nov 6, 2026
Member
|
Thanks, let's try this. |
Contributor
Author
|
just tested with my 2nd account.. it seems to work as expected 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check the reviewers permissions instead of relying on github.event.review.author_association which does not work for regular maintainers.
I tested this fix in https://github.com/phpstan/phpstan-src/pulls?q=sort%3Aupdated-desc+is%3Apr+state%3Aopen+